Update from 1.4.4 to 1.5.0 multiple issues

[Maks3w]

Does this project follow semantic versioning?

Undefined property: stdClass::$definitions
 C:\Proyectos\SwaggerAssertions\vendor\justinrainbow\json-schema\src\JsonSchema\RefResolver.php:270
 C:\Proyectos\SwaggerAssertions\vendor\justinrainbow\json-schema\src\JsonSchema\RefResolver.php:238
 C:\Proyectos\SwaggerAssertions\vendor\justinrainbow\json-schema\src\JsonSchema\RefResolver.php:123
 C:\Proyectos\SwaggerAssertions\src\SchemaManager.php:201
 C:\Proyectos\SwaggerAssertions\src\SchemaManager.php:65
 C:\Proyectos\SwaggerAssertions\src\PhpUnit\ResponseBodyConstraint.php:86
 C:\Proyectos\SwaggerAssertions\src\PhpUnit\ResponseBodyConstraint.php:52
 C:\Proyectos\SwaggerAssertions\src\PhpUnit\AssertsTrait.php:39
 C:\Proyectos\SwaggerAssertions\tests\PhpUnit\AssertsTraitTest.php:34

The maximum stack depth has been exceeded
 C:\Proyectos\SwaggerAssertions\vendor\justinrainbow\json-schema\src\JsonSchema\RefResolver.php:105
 C:\Proyectos\SwaggerAssertions\src\SchemaManager.php:201
 C:\Proyectos\SwaggerAssertions\src\SchemaManager.php:232
 C:\Proyectos\SwaggerAssertions\src\SchemaManager.php:77
 C:\Proyectos\SwaggerAssertions\src\PhpUnit\ResponseHeadersConstraint.php:87
 C:\Proyectos\SwaggerAssertions\src\PhpUnit\ResponseHeadersConstraint.php:52
 C:\Proyectos\SwaggerAssertions\tests\PhpUnit\ResponseHeadersConstraintTest.php:42

From https://github.com/Maks3w/SwaggerAssertions test suite.

[bighappyface]

@Maks3w welcome back.

There is discussion (see issues) around the addition of an exception in 1.4.4 for maximum depth, and this is the first I am seeing of anything related to the definitions property. Thanks for the report.

What about semver are you expecting presently?

[Maks3w]

Maximum depth exception was added on 1.4.4. The issue is upgrading from 1.4.4 to 1.5.0

I expect no backward compatibility issues while upgrading between minor versions.

[Maks3w]

$definitions it's part of the json schema under test (Swagger v2.0 specification)

[Maks3w]

This still broken in 1.6.1

[bighappyface]

See #210

[jojo1981]

See #245

[bighappyface]

Closed with #245

[Maks3w]

Can you elaborate why #174 is related to this?

[jojo1981]

@Maks3w I think @bighappyface did mean #245

[bighappyface]

@jojo1981 @Maks3w yes, I meant #245

Sorry for the confusion