Fix: pro help page adaptation to dark mode #1431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1431 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 387 387
Branches 103 103
=========================================
Hits 387 387 ☔ View full report in Codecov by Sentry. |
idanidan29
changed the title
|
Hey @idanidan29 , for this issue I have already raised a pr and also reviewed , but not merged yet. |
|
thanks for letting me know @jagpreetrahi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Enhancement – Improves UI adaptability for dark mode.
Issue Number:
Screenshots/videos:
Summary
This PR ensures that the LinkedIn, email, and "Reach out" buttons, along with the TSC label in the title, properly adapt to dark mode. Previously, icons and text remained black, making them difficult to see in dark mode.
Does this PR introduce a breaking change?
no