Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update CONTRIBUTING-docs.md with instructions for adding metadata to markdown files #1101

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

techmannih
Copy link
Contributor

Issue Number:

This PR updates the CONTRIBUTING-docs.md file to include instructions on adding metadata (YAML front matter) to new markdown files.
Added guidelines for including metadata fields like title, section, date, author, and tags.

@techmannih techmannih requested a review from a team as a code owner November 9, 2024 16:23
Copy link

github-actions bot commented Nov 9, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 2884007

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1666a67) to head (2884007).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1101   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@techmannih
Copy link
Contributor Author

@DhairyaMajmudar @kwennB please review this PR

Copy link
Contributor

@kwennB kwennB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, and thank you for your quick response to this issue.
I have added some comments.

@kwennB
Copy link
Contributor

kwennB commented Nov 14, 2024

@valeriahhdez
Copy link
Contributor

@techmannih, thanks for your hard work on improving the contribution guide! Your changes have made it clearer and more user-friendly.

I do have a small issue regarding the level of detail in the steps. For straightforward tasks, providing too many steps might come across as condescending. To avoid this, we could simplify the instructions by providing a high-level overview and letting the reader fill in the details.

Let me know if you have any questions.

@techmannih
Copy link
Contributor Author

@kwennB please check now

Copy link
Contributor

@valeriahhdez valeriahhdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work on this PR!

We don't add detailed step-by-step instructions for straightforward tasks, like adding metadata to a .md file. I suggest adding a general instruction and letting the reader fill in the details themselves.

@techmannih
Copy link
Contributor Author

@valeriahhdez Thanks for the feedback!

I’ve updated the instructions to be more general as suggested. please check now

@valeriahhdez
Copy link
Contributor

Looking good @techmannih!

I left two more comments, but after you addressed them, it will be better to merge

@techmannih
Copy link
Contributor Author

@valeriahhdez
Which comments are still pending? I believe these have already been updated. Could you please revise them again

@valeriahhdez
Copy link
Contributor

@valeriahhdez Which comments are still pending? I believe these have already been updated. Could you please revise them again

@techmannih I tagged you in the comments I left a few minutes ago

@techmannih
Copy link
Contributor Author

Looking good @techmannih!

I left two more comments, but after you addressed them, it will be better to merge

@valeriahhdez Which comments are still pending? I think I might have misunderstood.

@valeriahhdez
Copy link
Contributor

valeriahhdez commented Nov 28, 2024

Hello @techmannih,

Have you had time to go through the last review I made on this PR?

@techmannih
Copy link
Contributor Author

Hey @valeriahhdez, which comments are still pending? I think I might have misunderstood. I have resolved all the conversations. Please tag me once more and then leave again.

@valeriahhdez
Copy link
Contributor

valeriahhdez commented Nov 29, 2024

@techmannih here are the screenshots of the comments that are pending to be addressed

Screen Shot 2024-11-29 at 11 28 06
Screen Shot 2024-11-29 at 11 28 34
Screen Shot 2024-11-29 at 11 28 52

@techmannih
Copy link
Contributor Author

@valeriahhdez sure, really sorry I am not getting these conservation
image

@valeriahhdez
Copy link
Contributor

LGTM

Good job @techmannih

Copy link
Contributor

@valeriahhdez valeriahhdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, googd job @techmannih

Copy link
Contributor

@kwennB kwennB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀🚀

@kwennB
Copy link
Contributor

kwennB commented Dec 10, 2024

@DhairyaMajmudar The docs team approves this PR.

@kwennB kwennB added the ready-to-merge PR that already has two approvals. label Dec 12, 2024
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjagm benjagm merged commit ed3fd75 into json-schema-org:main Dec 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge PR that already has two approvals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[📝 Docs]: Update docs contributing guide: "Add meta-data to newly created markdown file".
4 participants