link-redirect-fix #1042
link-redirect-fix #1042
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1042 +/- ##
===========================================
- Coverage 100.00% 99.47% -0.53%
===========================================
Files 10 10
Lines 373 380 +7
Branches 94 97 +3
===========================================
+ Hits 373 378 +5
- Misses 0 2 +2 ☔ View full report in Codecov by Sentry. |
|
looks great, but would it be possible to clarify:
|
There was a problem hiding this comment.
Pls. remove package-lock.json file since we are using yarn as package manager
There was a problem hiding this comment.
remove newly installed dependencies since it seems like they are not used in the codebase
There was a problem hiding this comment.
This file is obtained from .github repo as submodule, for doing changes in it you have to perform changes in that repo.
Revert the changes related to it.
There was a problem hiding this comment.
This file is obtained from community repo as git submodule
Pls. revert changes related to it.
There was a problem hiding this comment.
Pls. revert these changes
There was a problem hiding this comment.
remove changes from yarn.lock file and uninstall newly installed dependencies
DhairyaMajmudar
added
the
Hacktoberfest-accepted
|
|
Ill Fork the repo again and create a new pull request soon @DhairyaMajmudar . Thank you |
No need to fork and create pr again you can commit changes in this PR also |
What kind of change does this PR introduce?
Bugfix: Fixes misdirection of pages.
Issue Number:
Closes #1038
Related to #___
Others?
Screenshots/videos:
If relevant, you can add screenshots or videos showing the issue and how it was fixed.
If relevant, did you update the documentation?
No documentation updates were needed.
Summary
This PR fixes a bug that caused misdirection of certain pages in the app. The routing logic was adjusted to correctly map the pages to their intended destinations.
Does this PR introduce a breaking change?
No, this PR does not introduce a breaking change.