Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref is delegation - try 3 #628

Merged
merged 3 commits into from
Jun 30, 2018

Conversation

Relequestual
Copy link
Member

@Relequestual Relequestual commented Jun 28, 2018

$ref no longer effects other properties in the same object.
Updated phrasing to align with current wording.

Resolves #514 and resolve #523
Opened in favour of #585

Copy link
Contributor

@handrews handrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just two really trivial comments.

All other properties in a "$ref" object MUST be ignored.
</t>
<t>
As the value of "$ref" is a URI Reference, this allows the posibility to externalise or
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: "possibility"

</t>
<t>
As the value of "$ref" is a URI Reference, this allows the posibility to externalise or
shard a schema across multiple files, and provides the ability to validate recursive structures
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm vaguely familiar with "shard" as a database term, but it feels a bit awkward here. I actually thought it was a typo for "share" and almost submitted the review with that comment. How about "or divide a schema across multiple files"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that sounds better. I actually originally used a different word, but for this PR changed to shard because of familiarity as a database term. I'll change this.

@handrews
Copy link
Contributor

Given that this PR has, in various forms, been up for well over the usual 14-day aging, and this latest iteration is a straightforward wording tweak to the uncontroversial part of the prior iterations, I'm going to go ahead and merge it so we can move forward with related work more easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keywords alongside of $ref What is "$ref" and how does it work?
2 participants