-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ref is delegation - try 3 #628
Ref is delegation - try 3 #628
Conversation
Updated phrasing to align with current wording. Resolves json-schema-org#514 and json-schema-org#523
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just two really trivial comments.
jsonschema-core.xml
Outdated
All other properties in a "$ref" object MUST be ignored. | ||
</t> | ||
<t> | ||
As the value of "$ref" is a URI Reference, this allows the posibility to externalise or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: "possibility"
jsonschema-core.xml
Outdated
</t> | ||
<t> | ||
As the value of "$ref" is a URI Reference, this allows the posibility to externalise or | ||
shard a schema across multiple files, and provides the ability to validate recursive structures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm vaguely familiar with "shard" as a database term, but it feels a bit awkward here. I actually thought it was a typo for "share" and almost submitted the review with that comment. How about "or divide a schema across multiple files"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that sounds better. I actually originally used a different word, but for this PR changed to shard because of familiarity as a database term. I'll change this.
Given that this PR has, in various forms, been up for well over the usual 14-day aging, and this latest iteration is a straightforward wording tweak to the uncontroversial part of the prior iterations, I'm going to go ahead and merge it so we can move forward with related work more easily. |
$ref no longer effects other properties in the same object.
Updated phrasing to align with current wording.
Resolves #514 and resolve #523
Opened in favour of #585