Split "requiredDependencies" out of "dependencies" #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"dependencies", with the schema behavior, moves to the validation spec with the other applicators. "requiredDependencies", with the property array behavior, stays in validation as an assertion alongside "required"
dlax
approved these changes
Mar 24, 2018
jsonschema-validation.xml
Outdated
| for further discussion. Further feedback is encouraged. | ||
| </cref> | ||
| This keyword specifies property requirements that are conditional | ||
| based on the presence of other properties. |
There was a problem hiding this comment.
I'm not sure this sentence is useful considering the one that follows (in fact, I cannot easily read it (but maybe it's because I'm not native English)). Also, most keyword's description start out by "The value of this keyword MUST be ..." so this one would be (is already) an exception with this sentence. Not a big deal, though :)
There was a problem hiding this comment.
Good points, let me see if I can rework it to be more consistent and clear.
Use language based on a combination of "required" and "properties", and make the simple description (the 2nd paragraph) more clear.
|
@dlax how does this version look? |
|
Looks good 👍 |
gregsdennis
added
clarification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"dependencies", with the schema behavior, moves to the validation
spec with the other applicators. "requiredDependencies", with
the property array behavior, stays in validation as an assertion
alongside "required"