Move "definitions" to core as "$defs", start appendix on moved/renamed keywords #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the text but does not change it aside from the keyword rename. Includes change log updates. Example and meta-schema updates to follow.
Since we're moving (and in a few cases, renaming or splitting) quite a few keywords, it seems worthwhile to include a brief accounting of which keywords and why they were moved or otherwise changed. This way if someone searches the new text for the old keywords, at least they'll find something useful. In the case of "definitions", also advise against redefining they keyword even though it is no longer technically a part either spec after being changed to "$defs".
Keep "definitions" in the meta-schema for now to discourage re-definition. This may be re-considered depending on how the vocabulary proposals develop before this draft is published.
instead of "definitions"
instead of "definitions"
dlax
approved these changes
Mar 18, 2018
gregsdennis
added
clarification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes updates of the meta-schemas and examples to match.
Addresses #512
NOTE: There are multiple commits to make this easy, as it's all very simple and mostly mechanical, but if you look at it all together it looks big. The commits in order: