-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a "writeOnly" (formerly "secret") annotation #433
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite straightforward, so why not?
This is for passwords and other senstive or write-only fields.
Last call-ish on this one! Given it's simplicity, and the fact that I'd like to move into the feature-freeze editorial review on Friday, I will probably merge this on Friday even though it will be one day early. |
I'm not sure if secret is the way to advertise the feature, even if it's what the keyword is being used for. I think writeOnly would be a tad more consistent? Writing things but not being able to see them after is what they're asking for, no? |
@philsturgeon I'm open to @dlax and/or @chrisdostert how do you feel about it? Thinking a bit more, I can see Does that seem like a good distinction? |
This is more data-oriented and less UI-oriented, and allows for further refinements to be handled in a UI vocabulary.
I reworked this as Another use case for |
Fantastic. |
@philsturgeon @handrews I think both are useful & have specific semantics & use cases. Knowing something is write only is not the same as knowing it's secret. For example, think of logging; write-only instances might be included in logs whereas secret instances might not. |
@chrisdostert yes, agreed they are both useful. The proposal is that There is a similar separation for So... |
This spec is for generic usage, presentation ideas go in json-schema-org/json-schema-vocabularies#2 |
Also, you can easily treat |
@chrisdostert if you want to argue that we should not move forward with |
Of course if you come back next week with new objections we can continue to discuss changes, I would just like to include this in the "final review" announcement for this weekend. |
This is for passwords and other senstive or write-only fields.
This addresses #249.