Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate srv files from jsk_pcl_ros to jsk_recognition_msgs #644

Conversation

@k-okada
Copy link
Member

k-okada commented Nov 22, 2016

need to wait for jade release? -> ros/rosdistro#13266, please restart travis after new deb is releasead @wkentaro

@k-okada
Copy link
Member

k-okada commented Nov 23, 2016

Background

Some packages in jsk_visualization depends on jsk_pcl_ros because it uses the srv files.
But jsk_pcl_ros is a very large package and the dependency should be avoided ideally.
The solution is placing msg/srv files into jsk_recognition_msgs.

Plans

Merge this after jsk_recognition_msgs is released: http://repositories.ros.org/status_page/ros_indigo_default.html?q=jsk_recognition_msgs

  • Release this pacakge.
  • Remove jsk_pcl_ros/srv.
  • Release jsk_pcl_ros.

Related PRs

jsk-ros-pkg/jsk_recognition#1827
jsk-ros-pkg/jsk_recognition#1914

@k-okada k-okada merged commit ecd8f96 into jsk-ros-pkg:master Nov 23, 2016
@wkentaro wkentaro deleted the migrate-srv-jsk_pcl_ros-to-jsk_recognition_msgs branch November 23, 2016 11:05
@k-okada
Copy link
Member

k-okada commented Dec 14, 2016

@wkentaro should we add version_gte >= 1.0.0 for jsk_recognition_msg?

@wkentaro
Copy link
Member Author

@k-okada You're right. Thanks. -> #651

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants