Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor roseus_tutorials #436

Merged
merged 19 commits into from
May 28, 2016
Merged

Conversation

@furushchev furushchev force-pushed the roseus-tutorials branch 2 times, most recently from 7447996 to 79742c0 Compare April 10, 2016 07:47
@furushchev
Copy link
Member Author

wait for jsk-ros-pkg/jsk_travis#235

@furushchev
Copy link
Member Author

I rewrote tabletop object detection with jsk_pcl.
Now roseus_tutorials don't have to depend on ros-interactive-manipulation/tabletop_object_perception repository.

@furushchev furushchev closed this Apr 11, 2016
@furushchev furushchev reopened this Apr 11, 2016
@furushchev
Copy link
Member Author

Anyway current codes do not work. And this PR also includes refactoring codes.
Is it possible to merge after only removing dependency to tabletop_object_perception and disable test?

@furushchev
Copy link
Member Author

Removed dependency to tabletop_object_perception
@k-okada How do you think about my previous comment?

@k-okada
Copy link
Member

k-okada commented Apr 14, 2016

so you mean

  • use tabletop_object_perception for demo ( or jsk_pcl_ros version )???
  • add code using tabletop_object_perception into the roseus_tutorials, but do not add them to the test.

@furushchev
Copy link
Member Author

@k-okada

  • there are already codes with tabletop_object_perception in roseus_tutorials
  • I updated codes and now it supports if you download and compile the latest tabletop_object_perception
  • New version of tabletop demo is in jsk_pcl_ros and it does no more depend on roseus.

@furushchev
Copy link
Member Author

@k-okada How do you think of this?

@furushchev
Copy link
Member Author

failed on some env. restarting

[roseus:make]   /opt/ros/jade/share/rostest/cmake/../../../bin/rostest --pkgdir=/workspace/ros/ws_jsk_roseus/src/jsk_roseus/roseus --package=roseus --results-filename test_test-multi-queue.xml --results-base-dir /workspace/ros/ws_jsk_roseus/build/roseus/test_results /workspace/ros/ws_jsk_roseus/src/jsk_roseus/roseus/test/test-multi-queue.test                                            
[roseus:make] INFO: cannot create a symlink to latest log directory: [Errno 17] File exists
[roseus:make] ... logging to /workspace/jsk-ros-pkg/jsk_roseus/log/rostest-93e6427f9ba0-12150.log
[roseus:make] ... logging to /workspace/jsk-ros-pkg/jsk_roseus/log/rostest-93e6427f9ba0-12151.log
[roseus:make] [ROSUNIT] Outputting test results to /workspace/ros/ws_jsk_roseus/build/roseus/test_results/roseus/rostest-test_test-compile-message.xml
[roseus:make] Traceback (most recent call last):
[roseus:make]   File "/opt/ros/jade/share/rostest/cmake/../../../bin/rostest", line 36, in     
[roseus:make]     rostestmain()
[roseus:make]   File "/opt/ros/jade/lib/python2.7/dist-packages/rostest/__init__.py", line 273, in rostestmain                               
[roseus:make]     _main()                                                             
[roseus:make]   File "/opt/ros/jade/lib/python2.7/dist-packages/rostest/rostest_main.py", line 167, in rostestmain                                        
[roseus:make]     results_file = xmlResultsFile(pkg, outname, is_rostest, env=env)                                                             
[roseus:make]   File "/opt/ros/jade/lib/python2.7/dist-packages/rosunit/core.py", line 102, in xml_results_file
[roseus:make]     raise IOError("cannot create test results directory [%s]. Please check permissions."%(test_dir))                                                       
[roseus:make] IOError: cannot create test results directory [/workspace/ros/ws_jsk_roseus/build/roseus/test_results/roseus]. Please check permissions.

@furushchev
Copy link
Member Author

travis passed.
@k-okada How do you think of merging this PR? (refer: #436 (comment) )

@k-okada k-okada merged commit ddf52eb into jsk-ros-pkg:master May 28, 2016
@furushchev furushchev deleted the roseus-tutorials branch May 28, 2016 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants