pr2-interface.l: add :go-pos-unsafe, :go-pos-unsafe-no-wait, :go-pos-unsafe-wait #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[pr2eus] fix go-pos-unsafe
k-okada
added a commit
that referenced
this pull request
Aug 11, 2015
pr2-interface.l: add :go-pos-unsafe, :go-pos-unsafe-no-wait, :go-pos-unsafe-wait
|
Did you check on real robot? |
|
Oh, I didn't know specification/convention of return value. |
| (/= counter 0)) ;; try at least 1 time | ||
| (progn | ||
| (setq go-pos-unsafe-goal-msg nil) ;; go-pos-unsafe-wait has been called | ||
| (return-from :go-pos-unsafe-wait nil)) |
There was a problem hiding this comment.
why returns nil? I assume t here
If you agree, I create PR to fix.
There was a problem hiding this comment.
@h-kamada Thanks for review. Created another PR.
furushchev
pushed a commit
to furushchev/jsk_pr2eus
that referenced
this pull request
Sep 14, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please check this on real robot @h-kamada