[jsk_maps] rename start_empty_map.launch and standardize as other map launch #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 18, 2022
knorth55
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rename
start_empty_map.launchtostart_map_empty_world.launchin order to standardize as other map launch.other map launches' name are
start_map_[eng2|eng8].launch, so the launch forempty_worldshould bestart_map_empty_world.launch.the file name rule is used to launch in
pr2.launchandfetch_bringup.launch.I add symbolic link to keep the old filename launch, too.
https://github.com/jsk-ros-pkg/jsk_robot/blob/5c3fce88184e953ba753c83b53bdb07c806771eb/jsk_pr2_robot/jsk_pr2_startup/pr2.launch#L62
https://github.com/jsk-ros-pkg/jsk_robot/blob/5c3fce88184e953ba753c83b53bdb07c806771eb/jsk_fetch_robot/jsk_fetch_startup/launch/fetch_bringup.launch#L185