Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate srv files from jsk_pcl_ros to jsk_recognition_msgs #1204

Conversation

wkentaro
Copy link
Member

@wkentaro wkentaro commented Oct 22, 2016

Background

Some packages in jsk_visualization depends on jsk_pcl_ros because it uses the srv files.
But jsk_pcl_ros is a very large package and the dependency should be avoided ideally.
The solution is placing msg/srv files into jsk_recognition_msgs.

Plans

  1. Merge this after jsk_recognition_msgs is released: http://repositories.ros.org/status_page/ros_indigo_default.html?q=jsk_recognition_msgs
  2. Release this pacakge.
  3. Remove jsk_pcl_ros/srv.
  4. Release jsk_pcl_ros.

Related PRs

@k-okada
Copy link
Member

k-okada commented Nov 22, 2016

need to add source for hydro?

@wkentaro wkentaro force-pushed the migrate-srv-jsk_pcl_ros-to-jsk_recognition_msgs branch from b2ee712 to e39bcc6 Compare November 24, 2016 11:38
@wkentaro
Copy link
Member Author

@k-okada Thank you. I added.

@wkentaro wkentaro force-pushed the migrate-srv-jsk_pcl_ros-to-jsk_recognition_msgs branch from e39bcc6 to d9a8fbc Compare November 24, 2016 13:02
@k-okada k-okada merged commit 2fb28f0 into jsk-ros-pkg:master Nov 26, 2016
@wkentaro wkentaro deleted the migrate-srv-jsk_pcl_ros-to-jsk_recognition_msgs branch November 26, 2016 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants