Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_demo_common/euslisp/pr2-action.l] fix: add '_lk' to link name #1029

Merged
merged 1 commit into from
Aug 13, 2015

Conversation

furushchev
Copy link
Member

fix for change of calling link name directly in pr2-interface

@furushchev
Copy link
Member Author

Your test run exceeded 50 minutes.

please restart travis

@k-okada
Copy link
Member

k-okada commented Aug 10, 2015

from discussion -> jsk-ros-pkg/jsk_model_tools#18
we're encouraged to use :link "name" ?? (i think @snozawa is the expert on this issue)

@furushchev
Copy link
Member Author

@k-okada OK I fixed.

k-okada added a commit that referenced this pull request Aug 13, 2015
[jsk_demo_common/euslisp/pr2-action.l] fix: add '_lk' to link name
@k-okada k-okada merged commit 046990a into jsk-ros-pkg:master Aug 13, 2015
@furushchev furushchev deleted the patch-1 branch August 13, 2015 07:21
@snozawa
Copy link
Contributor

snozawa commented Aug 13, 2015

Sorry for late reply.
Robot model .l from euscollada conversion has fast accessing method for joints and links.
Previously, the naming of these accessing methods are same as joint names and link names.
However, for some robots, joint name and link name are same and methods names conflicts.
So, @YoheiKakiuchi employ the naming like xx_lk for link accessing methods.

https://github.com/euslisp/jskeus/blob/master/irteus/test/robot-model-usage.l
is the unittest for robot properties accessors.

Recommended accessors are:

  • (send *robot* :link "torso_lift_link") : It can be robot independent codes because we can generalize "torso_lift_link" as robot's link name. But slow.
  • (send *robot* :torso_lift_link_lk) : Robot specific description and hard to re-use for other robots, but fast (because of no find processing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants