Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate srv files from jsk_pcl_ros to jsk_recognition_msgs #637

Conversation

wkentaro
Copy link
Member

@wkentaro wkentaro commented Oct 22, 2016

Background

Some packages in jsk_visualization depends on jsk_pcl_ros because it uses the srv files.
But jsk_pcl_ros is a very large package and the dependency should be avoided ideally.
The solution is placing msg/srv files into jsk_recognition_msgs.

Plans

  1. Merge this after jsk_recognition_msgs is released: http://repositories.ros.org/status_page/ros_indigo_default.html?q=jsk_recognition_msgs
  2. Release this pacakge.
  3. Remove jsk_pcl_ros/srv.
  4. Release jsk_pcl_ros.

Related PRs

@k-okada
Copy link
Member

k-okada commented Nov 21, 2016

@wkentaro

  1. please update this branch
  2. please add more explanation on Migrate srv files from jsk_pcl_ros to jsk_recognition_msgs #637 (comment), a) why we need this, b) what is the plan
  3. please update [Major Release] Move service files: jsk_pcl_ros -> jsk_recognition_msgs to reuse jsk_recognition#1827 (comment) once this PR is merged.

@wkentaro wkentaro force-pushed the migrate-srv-jsk_pcl_ros-to-jsk_recognition_msgs branch from b5c6889 to 07a746c Compare November 21, 2016 03:56
@wkentaro
Copy link
Member Author

Done all.

@k-okada k-okada merged commit f416fb2 into jsk-ros-pkg:master Nov 21, 2016
@wkentaro wkentaro deleted the migrate-srv-jsk_pcl_ros-to-jsk_recognition_msgs branch November 21, 2016 11:25
@k-okada
Copy link
Member

k-okada commented Nov 21, 2016

thank you, please update jsk-ros-pkg/jsk_recognition#1827 (comment) once this PR is merged.
BTW, why this PR passes? I think we do not release newer version of jsk_recognition to hydro..

@wkentaro
Copy link
Member Author

BTW, why this PR passes? I think we do not release newer version of jsk_recognition to hydro..

Maybe because they are only in lisp code and there's no tests..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants