Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix travis push build: Travis + Docker + jsk_travis==0.4.34 #1565

Merged
merged 5 commits into from
Nov 6, 2017

Conversation

wkentaro
Copy link
Member

@wkentaro wkentaro commented Oct 29, 2017

Close #1552
Close #1566
Close #1563
Close #1562
Close #1555
Close #1554
Close #1552

@wkentaro wkentaro force-pushed the fix_travis_push_build2 branch 2 times, most recently from c6aed03 to ec91be3 Compare October 30, 2017 18:07
@wkentaro wkentaro force-pushed the fix_travis_push_build2 branch from ec91be3 to a2a86ab Compare October 31, 2017 11:39
@wkentaro wkentaro changed the title Fix travis push build (2) Fix travis push build: Travis + Docker Oct 31, 2017
@wkentaro wkentaro changed the title Fix travis push build: Travis + Docker Fix travis push build: Travis + Docker + jsk_travis==0.4.33 Oct 31, 2017
@wkentaro wkentaro force-pushed the fix_travis_push_build2 branch from 242bbfc to d4d3f09 Compare October 31, 2017 15:29
@wkentaro
Copy link
Member Author

wkentaro commented Nov 1, 2017

screen shot 2017-11-01 at 18 28 20

I found that this approach is the only one solution at current. The test fail is caused by the issue reported/will be solved in jsk-ros-pkg/jsk_travis#349.

@@ -15,7 +17,9 @@ env:
- ROS_PARALLEL_JOBS="-j8"
- ROS_PARALLEL_TEST_JOBS="-j1"
- CATKIN_PARALLEL_TEST_JOBS="-j1"
- USE_JENKINS=true
- USE_JENKINS=false
- USE_TRAVIS=true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wkentaro What does it mean if USE_TRAVIS and USE_DOCKER are both true?
When I created this option, I assumed either one is true.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, so I set UES_JENKINS=false and USE_TRAVIS=true.

@wkentaro wkentaro changed the title Fix travis push build: Travis + Docker + jsk_travis==0.4.33 Fix travis push build: Travis + Docker + jsk_travis==0.4.34 Nov 1, 2017
@wkentaro
Copy link
Member Author

wkentaro commented Nov 2, 2017

Actually, I'm not sure how to fix below error only on precise:

Do you have any idea? @k-okada @furushchev

No packages found matching iproute2.
ERROR: the following packages/stacks could not have their rosdep keys resolved
to system dependencies:
jsk_tools: Cannot locate rosdep definition for [rosemacs]
jsk_data: No definition of [python-click] for OS version [precise]
libcmt: No definition of [libopencv-dev] for OS version [precise]
Continuing to install resolvable dependencies...
No packages found matching iproute2.
�[1mexecuting command [sudo -H apt-get install -y -qq iproute2]�[0m
E: Unable to locate package iproute2
No packages found matching iproute2.
ERROR: the following rosdeps failed to install
  apt: command [sudo -H apt-get install -y -qq iproute2] failed
  apt: Failed to detect successful installation of [iproute2]

@k-okada
Copy link
Member

k-okada commented Nov 2, 2017 via email

@wkentaro wkentaro requested a review from k-okada November 4, 2017 10:11
@furushchev furushchev added this to the 2.2.6 milestone Nov 6, 2017
@furushchev
Copy link
Member

Looks good to me.
@k-okada
Please merge this pull request if it is ok for you?

@k-okada k-okada merged commit 7643be0 into master Nov 6, 2017
@k-okada k-okada deleted the fix_travis_push_build2 branch November 6, 2017 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants