Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_tools] add ROS param set test #1535

Merged
merged 3 commits into from
Nov 14, 2017

Conversation

knorth55
Copy link
Member

@knorth55 knorth55 commented Jun 27, 2017

Usage

name: param name
timeout: timeout [second]
expected: expected value
<test test-name="rosparam_set"
      pkg="jsk_tools" type="test_rosparam_set.py">
  <rosparam>
    params
      - name: /test_param
        expected: true
        timeout: 10
  </rosparam>
<test>

@knorth55 knorth55 requested a review from wkentaro June 27, 2017 06:06
Copy link
Member

@wkentaro wkentaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found we can use list of dict instead of using ~param_0, ... ~param_N.
Please refer to https://github.com/ros/ros_comm/blob/lunar-devel/tools/rostest/nodes/publishtest#L41 .

And please consider sending PR to rostest when you have tim.
It has node for single param test: https://github.com/ros/ros_comm/blob/lunar-devel/tools/rostest/nodes/paramtest

@knorth55 knorth55 force-pushed the add-rosparam-test branch from f73abee to 964026d Compare June 28, 2017 04:50
@knorth55
Copy link
Member Author

updated!

<test test-name="rosparam_set"
      pkg="jsk_tools" type="test_rosparam_set.py">
  <rosparam>
    params
      - name: /test_param
        expected: true
        timeout: 10
  </rosparam>
<test>

@k-okada k-okada merged commit 8d8cece into jsk-ros-pkg:master Nov 14, 2017
@knorth55 knorth55 deleted the add-rosparam-test branch November 14, 2017 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants