Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_data][pr2_play.sh] support other rosbag arguments #1526

Merged
merged 4 commits into from
Jun 14, 2017

Conversation

furushchev
Copy link
Member

@furushchev furushchev commented Jun 1, 2017

e.g.

rosrun jsk_data pr2_play.sh data.bag -l --pause

@k-okada
Copy link
Member

k-okada commented Jun 5, 2017

https://travis-ci.org/jsk-ros-pkg/jsk_common/jobs/238639196

+ catkin_test_results --verbose --all build
Skipping "catkin_tools_prebuild/package.xml": 'tests'
Full test results for 'jsk_data/test_results/jsk_data/roslaunch-check_launch_pr2_play.launch.xml'
-------------------------------------------------
<?xml version="1.0" encoding="UTF-8"?>
<testsuite tests="1" failures="1" time="1" errors="0" name="roslaunch-check_launch_pr2_play.launch.xml">
  <testcase name="test_ran" status="run" time="1" classname="Results">
  <failure message="roslaunch check [/workspace/ros/ws_jsk_common/src/jsk_common/jsk_data/launch/pr2_play.launch] failed" type=""/>
  </testcase>
  <system-out><![CDATA[[
[/workspace/ros/ws_jsk_common/src/jsk_common/jsk_data/launch/pr2_play.launch]:
	Missing package dependencies: jsk_data/package.xml: tf2_ros
]]></system-out>
</testsuite>

@furushchev
Copy link
Member Author

@k-okada Thank you! Fixed!!

@k-okada
Copy link
Member

k-okada commented Jun 14, 2017

failing on hydro https://travis-ci.org/jsk-ros-pkg/jsk_common/builds/242412246

Skipping "assimp_devel/build/assimp-3.1.1/contrib/cppunit-1.12.1/contrib/xml-xsl/tests.xml": 'tests'
Full test results for 'jsk_data/test_results/jsk_data/roslaunch-check_launch_pr2_play.launch.xml'
-------------------------------------------------
<?xml version="1.0" encoding="UTF-8"?>
<testsuite tests="1" failures="1" time="1" errors="0" name="roslaunch-check_launch_pr2_play.launch.xml">
  <testcase name="test_ran" status="run" time="1" classname="Results">
  <failure message="roslaunch check [/workspace/ros/ws_jsk_common/src/jsk_common/jsk_data/launch/pr2_play.launch] failed" type=""/>
  </testcase>
  <system-out><![CDATA[[
[/workspace/ros/ws_jsk_common/src/jsk_common/jsk_data/launch/pr2_play.launch]:
	ROSLaunch config error: [/workspace/ros/ws_jsk_common/src/jsk_common/jsk_data/launch/pr2_play.launch] unknown <arg> attribute 'doc'
]]></system-out>
</testsuite>
-------------------------------------------------
Skipping "collada_urdf_jsk_patch/build/robot_model/src/collada_urdf/packa

@furushchev
Copy link
Member Author

@k-okada Too strict linting!, but ok, fixed not to use doc attr and use comment instead.

@k-okada k-okada merged commit 32bbdc6 into jsk-ros-pkg:master Jun 14, 2017
@furushchev furushchev deleted the other-args branch November 2, 2017 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants