Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_topic_tools] Show deprecation warning for jsk_logxxx logging functions #1524

Closed

Conversation

wkentaro
Copy link
Member

@wkentaro wkentaro commented May 29, 2017

By #1461, we found jsk_logxxx was not necessary, and we can just run rospy.logxxx.

@k-okada
Copy link
Member

k-okada commented May 31, 2017

[image_view2] [100%] [100%] Building CXX object CMakeFiles/image_view2.dir/image_view2.cpp.o
[image_view2] Building CXX object CMakeFiles/image_view2.dir/image_view2_node.cpp.o
[assimp_devel] [  6%] Building CXX object code/CMakeFiles/assimp_devel.dir/SGSpatialSort.cpp.o
[jsk_data] CMake Error at CMakeLists.txt:45 (find_package):
[jsk_data]   Could not find module Findroslint.cmake or a configuration file for package
[jsk_data]   roslint.
[jsk_data] 
[jsk_data]   Adjust CMAKE_MODULE_PATH to find Findroslint.cmake or set roslint_DIR to
[jsk_data]   the directory containing a CMake configuration file for roslint.  The file
[jsk_data]   will have one of the following names:
[jsk_data] 
[jsk_data]     roslintConfig.cmake
[jsk_data]     roslint-config.cmake
[jsk_data] 
[jsk_data] 
[jsk_data] 
[jsk_data] CMake Error at CMakeLists.txt:46 (roslint_python):
[jsk_data]   Unknown CMake command "roslint_python".
[jsk_data] 
[jsk_data] 
[jsk_data] -- Configuring incomplete, errors occurred!
[jsk_data] <== '/workspace/ros/ws_jsk_common/build/jsk_data/build_env.sh /usr/bin/cmake /workspace/ros/ws_jsk_common/src/jsk_common/jsk_data -DCATKIN_DEVEL_PREFIX=/workspace/ros/ws_jsk_common/devel -DCMAKE_INSTALL_PREFIX=/workspace/ros/ws_jsk_common/install' failed with return code '1'
Failed <== jsk_data                 [ 4.3 seconds ]

https://travis-ci.org/jsk-ros-pkg/jsk_common/jobs/237186573

@wkentaro
Copy link
Member Author

@furushchev Could you please review this?

Copy link
Member

@furushchev furushchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw your another PR about rospy.logwarn_once, but it is not yet available on indigo, right?
So basically LGTM, otherwise, it's better to use it on deprecation warning.

@wkentaro
Copy link
Member Author

rospy.logwarn_once and this PR is unrelated, if I understand your comment correctly.
But now I am reminded that the PR that must be addressed for this PR is ros/ros_comm#877, because current rospy.logxxx does not show the class name that is shown in roscpp.

@wkentaro
Copy link
Member Author

So, I need to wait for ros/ros_comm#877 because I want rospy.logxxx to show class name, too.
Thanks for your hint.

@wkentaro wkentaro closed this May 31, 2017
@wkentaro wkentaro deleted the deprecation_warning_jsk_logxxx branch May 31, 2017 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants