[jsk_topic_tools] Fix missing installation of jsk_topic_tools_test_nodelet.xml #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is critical because the xml file is declared in package.xml. If I install jsk_topic_tools with apt, launch file with nodelet won't work because of not found error. Could you please merge this and release next version, soon?
wkentaro
force-pushed
the
missing-install-nodelet-xml
branch
from
d6cf147 to
4d389b7
Compare
|
Ok released ros/rosdistro#12626 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is critical because the xml file is declared in package.xml.
If I install jsk_topic_tools with apt, launch file with nodelet
won't work because of not found error.
Could you please merge this and release next version, soon?