Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_tools] Copy rviz display to duplicate same config #1352

Closed
wants to merge 1 commit into from

Conversation

wkentaro
Copy link
Member

@wkentaro wkentaro commented Mar 7, 2016

Added:

  • jsk_tools/bin/copy_rviz_display.py

1

## 2

## 3

@wkentaro wkentaro changed the title [jsk_tools] Copy rviz display for duplicate same config [jsk_tools] Copy rviz display to duplicate same config Mar 7, 2016
@wkentaro wkentaro force-pushed the copy-rviz-display branch 2 times, most recently from 8c04960 to a913f13 Compare March 8, 2016 03:32
@wkentaro
Copy link
Member Author

wkentaro commented Mar 8, 2016


[jsk_tilt_laser] /workspace/ros/ws_jsk_common/src/jsk_common/jsk_tilt_laser/src/spin_laser_snapshotter.cpp:36:21: fatal error: ros/ros.h: No such file or directory 

[jsk_tilt_laser]  #include                                           

[jsk_tilt_laser]                      ^                                         

[jsk_tilt_laser] compilation terminated.                                        

[jsk_tools] -- Detecting CXX compiler ABI info - done                           

[jsk_tilt_laser] make[2]: *** [CMakeFiles/spin_laser_snapshotter.dir/src/spin_laser_snapshotter.cpp.o] Error 1 

[jsk_tilt_laser] make[1]: *** [CMakeFiles/spin_laser_snapshotter.dir/all] Error 2 

[jsk_tilt_laser] make[1]: *** Waiting for unfinished jobs....     

@k-okada
Copy link
Member

k-okada commented Mar 8, 2016

this is interesting,
you need to use catkin_INCLUDE_DIR
https://github.com/jsk-ros-pkg/jsk_common/blob/master/jsk_tilt_laser/CMakeLists.txt#L21

I'm start seing this very recently, something has changed in catkin?
code-iai/snap_map_icp#6

◉ Kei Okada

On Tue, Mar 8, 2016 at 12:48 PM, Kentaro Wada [email protected]
wrote:

[jsk_tilt_laser] /workspace/ros/ws_jsk_common/src/jsk_common/jsk_tilt_laser/src/spin_laser_snapshotter.cpp:36:21: fatal error: ros/ros.h: No such file or directory

[jsk_tilt_laser] #include

[jsk_tilt_laser] ^

[jsk_tilt_laser] compilation terminated.

[jsk_tools] -- Detecting CXX compiler ABI info - done

[jsk_tilt_laser] make[2]: *** [CMakeFiles/spin_laser_snapshotter.dir/src/spin_laser_snapshotter.cpp.o] Error 1

[jsk_tilt_laser] make[1]: *** [CMakeFiles/spin_laser_snapshotter.dir/all] Error 2

[jsk_tilt_laser] make[1]: *** Waiting for unfinished jobs....


Reply to this email directly or view it on GitHub
#1352 (comment)
.

@snozawa
Copy link
Contributor

snozawa commented Mar 8, 2016

I saw similar bug on other travis:
jsk-ros-pkg/jsk_control#560
In the above PR's case, ros-$ROS_DISTRO-roscpp is installed, but cannot be included from the program.

@wkentaro
Copy link
Member Author

wkentaro commented Mar 9, 2016

Thanks for your comments, @k-okada @snozawa .
I'm trying to fix this at #1353

Added:
  - jsk_tools/bin/copy_rviz_display.py
@wkentaro wkentaro force-pushed the copy-rviz-display branch from a913f13 to 1e0b5a6 Compare March 11, 2016 12:26
@wkentaro
Copy link
Member Author

Sent PR to upstream: ros-visualization/rviz#977

@wkentaro wkentaro closed this Mar 14, 2016
@wkentaro wkentaro deleted the copy-rviz-display branch March 14, 2016 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants