Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[image_view2] Visualize label image to rgb #1235

Conversation

wkentaro
Copy link
Member

@wkentaro wkentaro force-pushed the image_view2-label-image-with-jsk-recognition-utils branch 3 times, most recently from f085a69 to 4407bc5 Compare November 16, 2015 22:53
@wkentaro wkentaro force-pushed the image_view2-label-image-with-jsk-recognition-utils branch from 4407bc5 to 9f4d57f Compare November 26, 2015 08:16
@wkentaro
Copy link
Member Author

need to wait for release of jsk_recognition_utils


[image_view2] /workspace/ros/ws_jsk_common/src/jsk_common/jsk_ros_patch/image_view2/image_view2.cpp: In member function 'void image_view2::ImageView2::imageCb(const ImageConstPtr&)': 

[image_view2] /workspace/ros/ws_jsk_common/src/jsk_common/jsk_ros_patch/image_view2/image_view2.cpp:1184:9: error: 'labelToRGB' is not a member of 'jsk_recognition_utils' 

[image_view2]          jsk_recognition_utils::labelToRGB(input_image, original_image_); 

[image_view2]          ^                                                        

[image_view2] Linking CXX executable /workspace/ros/ws_jsk_common/devel/lib/image_view2/points_rectangle_extractor 

[image_view2] [100%] Built target points_rectangle_extractor                    

[jsk_topic_tools] Scanning dependencies of target mux                           

[jsk_topic_tools] [  9%] Building CXX object CMakeFiles/mux.dir/mux.cpp.o       

[jsk_topic_tools] Scanning dependencies of target passthrough                   

[jsk_topic_tools] [ 11%] Building CXX object CMakeFiles/passthrough.dir/passthrough.cpp.o 

[image_view2] make[2]: *** [CMakeFiles/image_view2.dir/image_view2.cpp.o] Error 1 

[image_view2] make[1]: *** [CMakeFiles/image_view2.dir/all] Error 2             

[image_view2] make: *** [all] Error 2                                           

[image_view2] <== '/workspace/ros/ws_jsk_common/build/image_view2/build_env.sh /usr/bin/make --jobserver-fds=3,4 -j' failed with return code '2' 

@garaemon
Copy link
Member

garaemon commented Dec 4, 2015

this is intermediate dependency between different repositories.

labelToRGB should defined in image_view2

@wkentaro
Copy link
Member Author

wkentaro commented Dec 4, 2015

this is intermediate dependency between different repositories.

what do you mean? You mean packages in jsk-ros-pkg/jsk_common should not depend on ones in jsk-ros-pkg/jsk_recognition?

jsk_recognition_utils does not depends on image_view2 so I think it works.

rospack depends jsk_recognition_utils | grep image_view2 

@garaemon
Copy link
Member

garaemon commented Dec 4, 2015

I think bidirectional dependency has cold-start problem.
jsk_common <-> jsk_recognition

@wkentaro
Copy link
Member Author

wkentaro commented Dec 4, 2015

hmm, I see, I will try put labelToRGB to more upstream.

@wkentaro wkentaro closed this Dec 4, 2015
@wkentaro wkentaro deleted the image_view2-label-image-with-jsk-recognition-utils branch December 4, 2015 09:19
@wkentaro
Copy link
Member Author

wkentaro commented Dec 4, 2015

maybe cv_bridge or image_view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants