Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[.travis.yml] Add test for jade #1003

Closed
wants to merge 1 commit into from

Conversation

wkentaro
Copy link
Member

PLEASE DON'T MERGE THIS NOW

ros-jade-pr2eus has not yet released.
Is these EXTRA_DEB necessary for all ROS versions of this pkg? @k-okada @garaemon

@wkentaro
Copy link
Member Author

Please wait for jsk-ros-pkg/jsk_travis#102 to be merged
and submodules to be updated.

@k-okada
Copy link
Member

k-okada commented Jun 19, 2015

If I undestand correctly, pr2eus is used in test code and we do not want to
depend jsk_common to pr2eus so install the as an extra deb

2015年6月18日木曜日、Kentaro [email protected]さんは書きました:

Please wait for jsk-ros-pkg/jsk_travis#102
jsk-ros-pkg/jsk_travis#102 to be merged
and submodules to be updated.


Reply to this email directly or view it on GitHub
#1003 (comment)
.

◉ Kei Okada

@garaemon
Copy link
Member

Yes, Correct

2015年6月19日金曜日、Kei [email protected]さんは書きました:

If I undestand correctly, pr2eus is used in test code and we do not want to
depend jsk_common to pr2eus so install the as an extra deb

2015年6月18日木曜日、Kentaro Wada<[email protected]
javascript:_e(%7B%7D,'cvml','[email protected]');>さんは書きました:

Please wait for jsk-ros-pkg/jsk_travis#102
jsk-ros-pkg/jsk_travis#102 to be merged
and submodules to be updated.


Reply to this email directly or view it on GitHub
<
#1003 (comment)

.

◉ Kei Okada


Reply to this email directly or view it on GitHub
#1003 (comment)
.

✉︎ from iPhone

@wkentaro
Copy link
Member Author

I see.
Are you planning to release pr2eus for jade soon? @k-okada
Or should I change the test code to adapt for jade test. I mean change to install pr2eus from source if it's the test for jade.

@k-okada
Copy link
Member

k-okada commented Jun 20, 2015

how about try NOT_TEST_INSTALL="true", to avoid test code, until pr2eus is
released.

◉ Kei Okada

On Fri, Jun 19, 2015 at 11:34 PM, Kentaro Wada [email protected]
wrote:

I see.
Are you planning to release pr2eus for jade soon? @k-okada
https://github.com/k-okada
Or should I change the test code to adapt for jade test. I mean change to
install pr2eus from source if it's the test for jade.


Reply to this email directly or view it on GitHub
#1003 (comment)
.

@k-okada
Copy link
Member

k-okada commented Jun 20, 2015

how about try NOT_TEST_INSTALL="true", to avoid test code,

this is wrong

@k-okada
Copy link
Member

k-okada commented Jun 21, 2015

create new PR for #1010

@k-okada k-okada closed this Jun 21, 2015
@wkentaro wkentaro deleted the add-jade-test branch October 28, 2015 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants