Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsk_tools is not released well #1413

Closed
wkentaro opened this issue Jun 15, 2016 · 6 comments
Closed

jsk_tools is not released well #1413

wkentaro opened this issue Jun 15, 2016 · 6 comments

Comments

@wkentaro
Copy link
Member

wkentaro commented Jun 15, 2016

I have error in jsk-ros-pkg/jsk_recognition#1747

I checked https://github.com/tork-a/jsk_common-release/blob/debian/indigo/jsk_tools/package.xml#L18-L40
Below should be included in apt depends:

  • python-colorama
  • python-termcolor
  • python-texttable
% pkgs=(python-percol python-colorama python-pygithub3 python-slacker-cli python-termcolor python-texttable)
for pkg in $pkgs; do
rosdep resolve $pkg;
done
#pip
percol
#apt
python-colorama
#pip
pygithub3
#pip
slacker-cli
#apt
python-termcolor
#apt
python-texttable
@wkentaro
Copy link
Member Author

Note that this is critical issue.

@k-okada
Copy link
Member

k-okada commented Jun 17, 2016

are you saying deb package of jsk_tools should have dependency to these python debs? may be I over-removed python depends, I'll fix this when we release next time.

k-okada@kokada-t440s:~$ aptitude show ros-indigo-jsk-tools
Package: ros-indigo-jsk-tools            
State: installed
Automatically installed: no
Version: 2.0.14-0trusty-20160514-212155-0700
Priority: extra
Section: misc
Maintainer: Ryohei Ueda <[email protected]>
Architecture: amd64
Uncompressed Size: 384 k
Depends: ros-indigo-axis-camera, ros-indigo-jsk-network-tools,
         ros-indigo-jsk-topic-tools, ros-indigo-pr2-computer-monitor,
         ros-indigo-rosbag, ros-indigo-rosemacs, ros-indigo-rosgraph-msgs,
         ros-indigo-rospy, ros-indigo-rqt-reconfigure
Conflicts: ros-indigo-jsk-tools
Description: Includes emacs scripts, ros tool alias generator, and launch doc generator.

Homepage: http://ros.org/wiki/jsk_tools

@wkentaro
Copy link
Member Author

are you saying deb package of jsk_tools should have dependency to these python debs?

Yes, and it causes import error in travis testing.

wkentaro added a commit to wkentaro/jsk_recognition that referenced this issue Jun 18, 2016
@k-okada
Copy link
Member

k-okada commented Jun 19, 2016

python-termcolor is not available on saucy

k-okada@kokada-t440s:~$ rosdep resolve python-termcolor --os ubuntu:trusty
#apt
python-termcolor
k-okada@kokada-t440s:~$ rosdep resolve python-termcolor --os ubuntu:saucy
#pip
termcolor

@wkentaro
Copy link
Member Author

I didn't notice that, sorry.
I will remove dependency on termcolor and use colorama only.

@wkentaro
Copy link
Member Author

Sent #1417

k-okada added a commit to tork-a/jsk_common-release that referenced this issue Jun 19, 2016
k-okada added a commit to tork-a/jsk_common-release that referenced this issue Jun 19, 2016
k-okada added a commit to tork-a/jsk_common-release that referenced this issue Jun 19, 2016
k-okada added a commit to tork-a/jsk_common-release that referenced this issue Jun 19, 2016
k-okada added a commit to tork-a/jsk_common-release that referenced this issue Jun 19, 2016
k-okada added a commit to tork-a/jsk_common-release that referenced this issue Jun 19, 2016
k-okada added a commit to tork-a/jsk_common-release that referenced this issue Jun 19, 2016
k-okada added a commit to tork-a/jsk_common-release that referenced this issue Jun 19, 2016
k-okada added a commit to tork-a/jsk_common-release that referenced this issue Jun 20, 2016
k-okada added a commit to tork-a/jsk_common-release that referenced this issue Jun 20, 2016
k-okada added a commit to tork-a/jsk_common-release that referenced this issue Jul 21, 2016
k-okada added a commit to tork-a/jsk_common-release that referenced this issue Jul 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants