[jsk_topic_tools] Why roscpp_tutorials is listed as build_depend?

[wkentaro]

@k-okada
Why jsk_topic_tools depends on roscpp_tutorials?
We can not test general tools in jsk_topic_tools by changing programs in roscpp_tutorials because of that.

I found this change 9cd6f44

[k-okada]

https://github.com/jsk-ros-pkg/jsk_common/pull/279/files

i think we used roscpp_tutorials at somewhere in test code

◉ Kei Okada

On Thu, Nov 12, 2015 at 12:33 AM, Kentaro Wada [email protected]
wrote:

@k-okada https://github.com/k-okada
Why jsk_topic_tools depends on roscpp_tutorials?
We can not test general tools in jsk_topic_tools by changing programs in
roscpp_tutorials because of that.

I found this change 9cd6f44
9cd6f44

—
Reply to this email directly or view it on GitHub
#1230.

[k-okada]

very hard to follow file history but may be originated at
8248415

◉ Kei Okada

On Thu, Nov 12, 2015 at 11:42 AM, Kei Okada [email protected]
wrote:

https://github.com/jsk-ros-pkg/jsk_common/pull/279/files

i think we used roscpp_tutorials at somewhere in test code

◉ Kei Okada

On Thu, Nov 12, 2015 at 12:33 AM, Kentaro Wada [email protected]
wrote:

@k-okada https://github.com/k-okada
Why jsk_topic_tools depends on roscpp_tutorials?
We can not test general tools in jsk_topic_tools by changing programs in
roscpp_tutorials because of that.

I found this change 9cd6f44
9cd6f44

—
Reply to this email directly or view it on GitHub
#1230.

[k-okada]

and still used in
https://github.com/jsk-ros-pkg/jsk_common/blob/master/jsk_topic_tools/test/test_topic_buffer_close_wait.test#L8

◉ Kei Okada

On Thu, Nov 12, 2015 at 11:45 AM, Kei Okada [email protected]
wrote:

very hard to follow file history but may be originated at
8248415

◉ Kei Okada

On Thu, Nov 12, 2015 at 11:42 AM, Kei Okada [email protected]
wrote:

https://github.com/jsk-ros-pkg/jsk_common/pull/279/files

i think we used roscpp_tutorials at somewhere in test code

◉ Kei Okada

On Thu, Nov 12, 2015 at 12:33 AM, Kentaro Wada [email protected]
wrote:

@k-okada https://github.com/k-okada
Why jsk_topic_tools depends on roscpp_tutorials?
We can not test general tools in jsk_topic_tools by changing programs in
roscpp_tutorials because of that.

I found this change 9cd6f44
9cd6f44

—
Reply to this email directly or view it on GitHub
#1230.

[k-okada]

that should be in test_depend but as far as I know ,rosdep did not install
package in test_depend

◉ Kei Okada

On Thu, Nov 12, 2015 at 11:49 AM, Kei Okada [email protected]
wrote:

and still used in
https://github.com/jsk-ros-pkg/jsk_common/blob/master/jsk_topic_tools/test/test_topic_buffer_close_wait.test#L8

◉ Kei Okada

On Thu, Nov 12, 2015 at 11:45 AM, Kei Okada [email protected]
wrote:

very hard to follow file history but may be originated at
8248415

◉ Kei Okada

On Thu, Nov 12, 2015 at 11:42 AM, Kei Okada [email protected]
wrote:

https://github.com/jsk-ros-pkg/jsk_common/pull/279/files

i think we used roscpp_tutorials at somewhere in test code

◉ Kei Okada

On Thu, Nov 12, 2015 at 12:33 AM, Kentaro Wada <[email protected]

wrote:

@k-okada https://github.com/k-okada
Why jsk_topic_tools depends on roscpp_tutorials?
We can not test general tools in jsk_topic_tools by changing programs
in roscpp_tutorials because of that.

I found this change 9cd6f44
9cd6f44

—
Reply to this email directly or view it on GitHub
#1230.

[wkentaro]

That rosdep behavior seems changed at REP-0140.
https://github.com/ros-infrastructure/rep/pull/59/files#diff-3fa963019eccb75f6893ad65b7317a69R46

So currently, test_depend may work as we expect.

On Thu, Nov 12, 2015 at 11:52 AM, Kei Okada [email protected]
wrote:

that should be in test_depend but as far as I know ,rosdep did not install
package in test_depend

◉ Kei Okada

On Thu, Nov 12, 2015 at 11:49 AM, Kei Okada [email protected]

wrote:

and still used in

https://github.com/jsk-ros-pkg/jsk_common/blob/master/jsk_topic_tools/test/test_topic_buffer_close_wait.test#L8

◉ Kei Okada

On Thu, Nov 12, 2015 at 11:45 AM, Kei Okada <[email protected]

wrote:

very hard to follow file history but may be originated at

8248415

◉ Kei Okada

On Thu, Nov 12, 2015 at 11:42 AM, Kei Okada <
[email protected]>
wrote:

https://github.com/jsk-ros-pkg/jsk_common/pull/279/files

i think we used roscpp_tutorials at somewhere in test code

◉ Kei Okada

On Thu, Nov 12, 2015 at 12:33 AM, Kentaro Wada <
[email protected]

wrote:

@k-okada https://github.com/k-okada
Why jsk_topic_tools depends on roscpp_tutorials?
We can not test general tools in jsk_topic_tools by changing programs
in roscpp_tutorials because of that.

I found this change 9cd6f44
<
9cd6f44

—
Reply to this email directly or view it on GitHub
#1230.

—
Reply to this email directly or view it on GitHub
#1230 (comment)
.

和田 健太郎 / Kentaro Wada
http://wkentaro.com