Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow for zero-length NDA_LLADDR #199

Closed
jsimonetti opened this issue Nov 27, 2023 · 0 comments · Fixed by #200
Closed

allow for zero-length NDA_LLADDR #199

jsimonetti opened this issue Nov 27, 2023 · 0 comments · Fixed by #200

Comments

@jsimonetti
Copy link
Owner

There are some setups where the kernel returns a neighbor entry that has a zero-length link-layer address.
It appears this is focussed around systemd-networkd, although this is not confirmed.

See prometheus/node_exporter#2849

This type of entry should not produce an error.
SuperQ added a commit to SuperQ/rtnetlink that referenced this issue Nov 27, 2023
@SuperQ
Allow empty neighbor LLAddress
45a032d 
The kernel sometimes returns empty LLAddress in NeighAttributes. Allow
this to be returned as a nil address.

Fixes: jsimonetti#199

Signed-off-by: SuperQ <[email protected]>
This was referenced Nov 27, 2023
Merged
Closed
jsimonetti added a commit that referenced this issue Nov 27, 2023
@jsimonetti
Allow for zero-length ND_LLADDR
98743e7 
Fixes #199
This change allows for neighbor entries with a
zero-length LLADDR attribute.
This has the side-effect that consumers of this
module might have to filter this entry, depending
on their usage.

Signed-off-by: Jeroen Simonetti <[email protected]>
jsimonetti added a commit that referenced this issue Nov 27, 2023
@jsimonetti
Allow for zero-length ND_LLADDR
265a7d7 
Fixes #199
This change allows for neighbor entries with a
zero-length LLADDR attribute.
This has the side-effect that consumers of this
module might have to filter this entry, depending
on their usage.

Signed-off-by: Jeroen Simonetti <[email protected]>
jsimonetti pushed a commit that referenced this issue Nov 27, 2023
@SuperQ
Allow empty neighbor LLAddress (#200)
4031cf8 
The kernel sometimes returns empty LLAddress in NeighAttributes. Allow
this to be returned as a nil address.

Fixes: #199

Signed-off-by: SuperQ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow empty neighbor LLAddress SuperQ/rtnetlink
1 participant
@jsimonetti