Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OSSF scorecard reporting #107

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

carpasse
Copy link
Contributor

@carpasse carpasse commented Mar 14, 2024

Main Changes

This pipeline will proactively report the status of the project (every day and when a push is done to master branch) including critical fields (CI-Tests, Contributors, Dependency-Update-Tool, Webhooks) that are missing while running via OSSF cron jobs.

Context

Changes related

It's also possible that some repositories in your organization are already being automatically tracked by OpenSSF in this CSV file via weekly cronjob. One caveat: Automatically tracked projects do not include ossf/scorecard#3438 in their analysis (CI-Tests,Contributors,Dependency-Update-Tool,Webhooks).

Source: openssf-scorecard-monitor documentation

Team discussion related

Ref: expressjs/security-wg#2
Report: https://kooltheba.github.io/openssf-scorecard-api-visualizer/#/projects/github.com/jshttp/http-errors/commit/206aa2c15635dc1212c06c279540972aa90e23ea

Changelog
c33f053 chore: add scorecard pipeline by @carpasse

@carpasse carpasse changed the title chore: add scorecard pipeline Add support for OSSF scorecard reporting Mar 14, 2024
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the work @carpasse.

I updated the report url in the PR description to https://kooltheba.github.io/openssf-scorecard-api-visualizer/#/projects/github.com/jshttp/http-errors/commit/206aa2c15635dc1212c06c279540972aa90e23ea as the previous one was pointing to express package 😉

@UlisesGascon
Copy link
Member

The CI is failing due #108, and it is not related to this PR as the change does not affect the source code or the existing GA pipelines.

I will merge this PR on next Monday, unless there are concerns.

@jonchurch
Copy link
Member

jonchurch commented Mar 15, 2024

Not worth blocking on, but is there a reason to use this ad hoc workflow vs the official ossf github action? Does this workflow do different things than the action or is otherwise preferred over the versioned and maintained action?

https://github.com/ossf/scorecard-action

@UlisesGascon
Copy link
Member

UlisesGascon commented Apr 29, 2024

Not worth blocking on, but is there a reason to use this ad hoc workflow vs the official ossf github action? Does this workflow do different things than the action or is otherwise preferred over the versioned and maintained action?

We use the same one (official one), for reference: expressjs/discussions#185 (comment)

@UlisesGascon UlisesGascon merged commit 2526505 into jshttp:master Apr 29, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants