forked from yamadashy/tech-blog-rss-feed
-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Maximum call stack size exceeded の修正の取り込み #2
Open
yamadashy
wants to merge
131
commits into
jser:main
Choose a base branch
from
yamadashy-sandbox:feature/merge-yamadashy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- TalentX: https://tech.talentx.co.jp/
Bumps [ejs](https://github.com/mde/ejs) from 3.1.9 to 3.1.10. - [Release notes](https://github.com/mde/ejs/releases) - [Commits](mde/ejs@v3.1.9...v3.1.10) --- updated-dependencies: - dependency-name: ejs dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
chore: fix typo
add: 新規フィード追加
…rn/ejs-3.1.10 build(deps): bump ejs from 3.1.9 to 3.1.10
…tch-dependencies chore(deps): update dependency renovate to v37.342.0
…de-major Draft: ESLint, yarnのmajor、その他のminor, patch バージョンアップ
chore: renovate でmajorもPRを作成するように。automerge: false
…dependencies chore(deps): update peaceiris/actions-gh-pages action to v4
feat: テストしやすいように改修 + テスト追加
…age-upgrade-major" This reverts commit f909f5e. # Conflicts: # yarn.lock
…rn/fast-xml-parser-4.4.1 build(deps): bump fast-xml-parser from 4.2.5 to 4.4.1
chore(11ty): configをtsにする
…dependencies chore(deps): update dependency googleapis to v142
…tch-dependencies chore(deps): update minor and patch dependencies
Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.5 to 4.0.8. - [Release notes](https://github.com/micromatch/micromatch/releases) - [Changelog](https://github.com/micromatch/micromatch/blob/4.0.8/CHANGELOG.md) - [Commits](micromatch/micromatch@4.0.5...4.0.8) --- updated-dependencies: - dependency-name: micromatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…rn/micromatch-4.0.8 build(deps): bump micromatch from 4.0.5 to 4.0.8
fix(feed): 一部のフィードでMaximum call stack size exceededが発生する
…dashy # Conflicts: # src/common/constants.js # src/common/eleventy-cache-option.js # src/feed/generate-feed-command.ts # src/feed/utils/feed-crawler.ts # src/resources/feed-info-list.ts
feat(feed): フィード生成コマンドのエラーハンドリング
…tch-dependencies chore(deps): update yarn to v4.4.1
…dashy # Conflicts: # src/feed/generate-feed-command.ts
yamadashy
changed the title
Feature/merge yamadashy
fix: Maximum call stack size exceeded の修正
Aug 24, 2024
yamadashy
changed the title
fix: Maximum call stack size exceeded の修正
fix: Maximum call stack size exceeded の修正の取り込み
Aug 24, 2024
yamadashy
commented
Aug 24, 2024
@@ -0,0 +1,184 @@ | |||
import htmlmin from 'html-minifier-terser'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tsに移行してます。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #1
Maximum call stack size exceeded
エラーの対応を tech-blog-rss-feed に入れましたので、mainを取り込んだPRを作成してみました。実際の修正はこちらのPRです
修正されたことはこちらで確認しております。
お手隙でご確認いただけると幸いです。