Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec update: treat URLs without a special scheme differently #63

Closed
wants to merge 1 commit into from

Conversation

domenic
Copy link
Member

@domenic domenic commented Dec 29, 2016

This matches whatwg/url#185.

This one also runs into several failing tests from the new WPT set. I suspect they are spec bugs, but they could be test bugs or spec-translation-into-JS bugs. They are:

1) Web platform tests parsing <sc://ñ> against <about:blank>:

      AssertionError: href
      + expected - actual

      -sc://%C3%B1/
      +sc://%C3%B1
 2) Web platform tests setters host <view-source+http://example.net/path>.host = "example.com\stuff" \ is not a delimiter for non-special schemes, and it’s invalid in a domain:

      AssertionError: 'view-source+http://example.com\\stuff/path' == 'view-source+http://example.net/path'
      + expected - actual

      -view-source+http://example.com\stuff/path
      +view-source+http://example.net/path
  3) Web platform tests setters hostname <view-source+http://example.net/path>.hostname = "example.com\stuff" \ is not a delimiter for non-special schemes, and it’s invalid in a domain:

      AssertionError: 'view-source+http://example.com\\stuff/path' == 'view-source+http://example.net/path'
      + expected - actual

      -view-source+http://example.com\stuff/path
      +view-source+http://example.net/path

/cc @annevk

We should not merge this until the WPT PRs make it into master

@domenic
Copy link
Member Author

domenic commented Jan 17, 2017

Not sure why GitHub isn't reflecting my force-push here... might have to close and open a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant