Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin tests to a specific commit #39

Closed
domenic opened this issue Jan 19, 2016 · 0 comments
Closed

Pin tests to a specific commit #39

domenic opened this issue Jan 19, 2016 · 0 comments

Comments

@domenic
Copy link
Member

domenic commented Jan 19, 2016

Having tests fail if upstream is updated is kind of sad; we acknowledge our current revision in the README and the tests should be for that revision.

Also we probably want the ability to point at PR branches.

I can probably work this in to my PR. Filing it in case I forget.
mattclough1 pushed a commit to mattclough1/whatwg-url that referenced this issue Oct 14, 2021
1.5.2: guard checks for allowed attributes correctly to avoid an unde…
3dc043e 
…fined property error. Thanks to Zeke. Closes jsdom#39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@domenic