Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't an unreleased package start at initial version (0.0.0) rather than calculated from all changes? #702

Open
JeremyJonas opened this issue May 17, 2023 · 1 comment

Comments

@JeremyJonas
Copy link

New version will be calculated based on all changes since first commit.

If I have a package in my monorepo that does not have a release tag, I would expect that it would start at 0.0.0, however it starts at 1.0.0, assuming it is because in my long git history there are "BREAKING CHANGES" listed.

What is the use case for "New version will be calculated based on all changes since first commit. " rather than just 0.0.0?

Wondering if it would make sense to add an initialVersion option to the @jscutlery/semver:version, which if defined would by-pass the calculation of the default functionality. Additionally, this could act as a "minimum version" as well to support graduating a package from 0.0.0 => 1.0.0.

  • If initialVersion is undefined, use current functionality
  • If initialVersion is defined, and the new version is lower than the initialVersion, then the defined initialVersion is used

Currently, how do you graduate a package if entire release process is CI/CD driven? It would be great to simply update initialVersion=1.0.0 to graduate a package, which could get handled via CI/CD release without manually have to manage "releaseAs".

@ianldgs
Copy link

ianldgs commented Aug 24, 2023

Related:
#444 (comment)
(set initial version on the package.json)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants