-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Override initial commit hash for fallback #444
Comments
Couldn't the first version be read from the package.json? |
@edbzn friendly ping on this! We just got an issue (again) because gitlab ci (and other ci tools) do a shallow clone of the repo. Allowing to read the version from the package.json would really help here. |
Hey @ianldgs, we don't want to make semver reading the package.json file, it would introduce more complexity and weird scenarios where the version is wrongly calculated. For example, how can we know the point from where to calculate the new version if there's no marker (tag) in the commit history? It would result in an inconsistent version calculation because it would take the whole history even if only a few commits are involved since the last release. For this reason, semver is only tag-based. It comes with cons but it's in my opinion the safest way to go. |
It could look at commits since On branches (PRs), we set the nx |
So, @edbzn, what do you think? Would you accept a PR implementing this? |
Hi guys, was creating a new application to add to a long running monorepo.
For quick checkout we are shallow cloning the repository, which means the initial commit is never available
Could we override this with the
--base
input instead to avoid the following:New version will be calculated based on all changes since first commit. ?
The text was updated successfully, but these errors were encountered: