-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSON tags for input structs as well #90
Conversation
Thanks for taking a crack at this:
See https://github.com/jschaf/pggen/blob/main/ARCHITECTURE.md for the high-level overview of the compilation phases. I traced the specific steps for pggen.arg below.
I think all you need to do is add RawName to TemplatedParam initialized to The tests will be upset until you run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with change to raw name
@jschaf Changed to RawName, this is ready to be merged. |
Nice! Can you update the acceptance tests to fix the check and then I'll merge.
|
I've gone ahead and updated the acceptance tests. Let's get this merged in and ship out a new release with these changes. Thank you @jschaf! |
Resolves #89. Two questions:
pggen.arg()
name here?