Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove deprecated ioutil #72

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Conversation

0xjac
Copy link
Contributor

@0xjac 0xjac commented Aug 18, 2022

Since go 1.16, ioutil has been deprecated. Its use triggers warnings
when linting with golangci-lint.

Migrate from ioutil to io and os, as specified at:
https://go.dev/doc/go1.16#ioutil

Since go 1.16, `ioutil` has been deprecated. Its use triggers warnings
when linting with `golangci-lint`.

Migrate from `ioutil` to `io` and `os`, as specified at:
https://go.dev/doc/go1.16#ioutil
@0xjac
Copy link
Contributor Author

0xjac commented Aug 18, 2022

@jschaf Based on my comment in !71, I've decided to just submit a second PR with the change.

Unfortunately it's a lot of small diffs to go through, so I thought a dedicated PR might be cleaner and easier to review. Of course the code compiles and make all passes.

@jschaf jschaf merged commit 0abc883 into jschaf:main Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants