Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setLayoutZoomRange doesn’t work on multilayer scenarios #99

Closed
jscastro76 opened this issue Nov 22, 2020 · 0 comments
Closed

setLayoutZoomRange doesn’t work on multilayer scenarios #99

jscastro76 opened this issue Nov 22, 2020 · 0 comments
Assignees
Labels
🪲 bug Something isn't working 📑 code improvement
Milestone

Comments

@jscastro76
Copy link
Owner

This is a consequence of the performance optimizations, now tb.update is only called once from the render method of the default layer created with the option multiLayer: true, so Mapbox when detects zoom changes and deactivates the render of the layer, the objects of the layer still visible.
We need to control the zoom changes as it’s made by Mapbox but call to tb.toggleLayer instead.
This could be made at tb.setLayoutZoomRange as it’s there where the zoom of a layer is being defined

@jscastro76 jscastro76 added 🪲 bug Something isn't working 📑 code improvement labels Nov 22, 2020
@jscastro76 jscastro76 added this to the v2.1.0. milestone Nov 22, 2020
@jscastro76 jscastro76 self-assigned this Nov 22, 2020
jscastro76 added a commit that referenced this issue Nov 24, 2020
Minor version by [@jscastro76](https://github.com/jscastro76), some enhancements and bugs.

#### ✨ Enhancements

- #5 (#5) Add a multi layer sample. [16-multilayer.html](https://github.com/jscastro76/threebox/blob/master/examples/16-multilayer.html)
- #95 (#95) `tb.add` should admit layer and source as optional params
- #96 (#96) `tb.setLayerHeigthProperty` depends on an internal feature on `obj.userData.feature`
- #98 (#98) Add an init param for multiLayer scenarios, that allows to create a default empty layer in threebox
- #99 (#99) `setLayoutZoomRange` doesn’t work on multilayer scenarios
- #101 (#101) `options.adjustment` must be on top of `options.anchor` not instead

#### 🪲 Bug fixes

- #94 (#94) tb.setLayoutPropery is not working when geojson features are not being used.
- #97 (#97) When `enableSelectingObjects` is active and not tooltips
- #100 (#100) Object anchors are not well calculated on duplicates when downscaled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Something isn't working 📑 code improvement
Projects
None yet
Development

No branches or pull requests

1 participant