Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug on utils.equal is only comparing objects, not when is only values #93

Closed
jscastro76 opened this issue Nov 21, 2020 · 0 comments
Closed

Bug on utils.equal is only comparing objects, not when is only values #93

jscastro76 opened this issue Nov 21, 2020 · 0 comments
Assignees
@jscastro76
Labels
🪲 bug Something isn't working
Milestone
v2.0.9.

Comments

@jscastro76
Copy link
Owner

When clone an object and its options.size is different in the second object, is not changing its size. This is due to the new method utils.equal that is thought for objects structures {x: 3, y: 3, z: 3} and not for values comparison.
@jscastro76 jscastro76 added the 🪲 bug Something isn't working label Nov 21, 2020
@jscastro76 jscastro76 added this to the v2.0.9. milestone Nov 21, 2020
@jscastro76 jscastro76 self-assigned this Nov 21, 2020
jscastro76 added a commit that referenced this issue Nov 21, 2020
@jscastro76
#93
4581e86
@jscastro76 jscastro76 mentioned this issue Nov 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jscastro76 jscastro76

Labels
🪲 bug Something isn't working
Projects
None yet
Milestone
v2.0.9.
Development

No branches or pull requests
1 participant
@jscastro76