Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: Why is this library not available on npm ? #74

Closed
PodaruDragos opened this issue Nov 3, 2020 · 3 comments
Closed

Question: Why is this library not available on npm ? #74

PodaruDragos opened this issue Nov 3, 2020 · 3 comments
Assignees
@jscastro76
Labels
🙏 suggestion Suggestion to consider ❓ question Further information is requested
Milestone
V2.0.8.

Comments

@PodaruDragos
Copy link

I was wondering why this library is not available on npm. Integrating this with typescript and a frontend framework seems like a tedios job.

Are there any plans to add it ? Is there any plan to add typescript type definitions ?
@PodaruDragos PodaruDragos changed the title Question: Why is library not available on npm ? Question: Why is this library not available on npm ? Nov 3, 2020
@jscastro76 jscastro76 added 🙏 suggestion Suggestion to consider ❓ question Further information is requested labels Nov 3, 2020
@jscastro76
Copy link
Owner

@PodaruDragos thanks for the interest in having this fork of Threebox in npm, I've seen many threebox forks uploaded included the one from peterqliu, but all of them from +1 one year ago with the v0.2 only.

In my personal case it's not an option to install it from npm in my prod environment that´s why I kept it as an standalone resource to link as a simple script to any web server. But having said so, it's an option I was evaluating, indeed I was checking the requirements to do it.

Migrating to typescript would be definitely a ton of extra work that I'm not able to manage so far, not sure if in the future I'll be forced to migrate it if my project requires it, so far I don't have any plan to migrate it.

@PodaruDragos
Copy link
Author

You don't need to actually migrate the code to typescript for type definitions.
If i will be using this i am willing to contribute to the typings if you are on board with it.

@jscastro76
Copy link
Owner

jscastro76 commented Nov 3, 2020 •
edited
Loading

@PodaruDragos Super happy to have a volunteer as contributor for that task if you want to lead it from a branch. I will only need a serious testing once we start to merge as I use this project in production, so I cannot approve PR if that breaks my project.

BTW I have already uploaded the plugin to npm as threebox-plugin. Thanks for the suggestion, I was already thinking on it but you pushed me forward.

@jscastro76 jscastro76 self-assigned this Nov 3, 2020
@jscastro76 jscastro76 added this to the V2.0.8. milestone Nov 3, 2020
@jscastro76 jscastro76 mentioned this issue Nov 4, 2020
Closed
jscastro76 added a commit that referenced this issue Nov 7, 2020
@jscastro76
## 2.0.8
7402b13 
Minor version by [@jscastro76](https://github.com/jscastro76), some enhancements and bugs.

#### ✨ Enhancements

- [**#73**](#73) `tb.dispose` must clean `tb.objectsCache`
- [**#74**](#74) Question: Why is this library not available on npm ?
- [**#75**](#75) Publish in npm
- [**#76**](#76) Refactor Objects.prototype._makeGroup
- [**#78**](#78) refactor var to const and let
- [**#80**](#80) Update example [15-performance.html](https://github.com/jscastro76/threebox/blob/master/examples/15-performance.html) Add built-in animation to example 15-performance.html windmill.

#### 🪲 Bug fixes

- [**#77**](#77) example 05-logistics raises an error removing the line
- [**#79**](#79) Some examples are not using `renderingMode: 3d` in the layer creation
jscastro76 added a commit that referenced this issue Nov 14, 2020
@jscastro76
## 2.0.8
0a8b716 
Minor version by [@jscastro76](https://github.com/jscastro76), some enhancements and bugs.

#### ✨ Enhancements

- #73 `tb.dispose` must clean `tb.objectsCache`
- #74 Question: Why is this library not available on npm ?
- #75 Publish in npm
- #76 Refactor Objects.prototype._makeGroup
- #78 refactor var to const and let
- #80 Update example [15-performance.html](https://github.com/jscastro76/threebox/blob/master/examples/15-performance.html) Add built-in animation to example 15-performance.html windmill.
- #82 Add a method `tb.getSunTimes`
- #85 We need an object compare method
- #87 Change `tb.getSunPosition` to accept lnglat coords instead of two params
- #88 Add night style change in 12-add3dmodel.html and 13-eiffel.html examples during night hours

#### 🪲 Bug fixes

- #42 Angular and Threebox. Solved an issue using a `mapboxgl.Point`line
- #77 example 05-logistics raises an error removing the line
- #79 Some examples are not using `renderingMode: 3d` in the layer creation
- #86 After #56 the feature that comes in userData is not being updated.

<br>

- - -
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jscastro76 jscastro76

Labels
🙏 suggestion Suggestion to consider ❓ question Further information is requested
Projects
None yet
Milestone
V2.0.8.
Development

No branches or pull requests
2 participants
@PodaruDragos @jscastro76