Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full refactor of tb.tube #214

Closed
jscastro76 opened this issue Apr 2, 2021 · 0 comments
Closed

Full refactor of tb.tube #214

jscastro76 opened this issue Apr 2, 2021 · 0 comments
Assignees
@jscastro76
Labels
📑 code improvement 🔗 external dependencies
Milestone
v2.2.1.

Comments

@jscastro76
Copy link
Owner

jscastro76 commented Apr 2, 2021 •
edited
Loading

Moving to Three v127, all the objects derived from Geometry have been removed. Because of this, the way tb.tube was working won't work anymore as it's being deprecated. To replace its functionality we will use TubeGeometry which derives from BufferGeometry
@jscastro76 jscastro76 added the ❓ question Further information is requested label Apr 2, 2021
@jscastro76 jscastro76 added this to the v2.2.1. milestone Apr 2, 2021
@jscastro76 jscastro76 self-assigned this Apr 2, 2021
@jscastro76 jscastro76 added 📑 code improvement 🔗 external dependencies and removed ❓ question Further information is requested labels Apr 2, 2021
@jscastro76 jscastro76 changed the title Full refactor of tb.tube Full refactor of tb.tube Apr 2, 2021
jscastro76 added a commit that referenced this issue Apr 3, 2021
@jscastro76
## 2.2.1
a2fb805 
Minor version by [@jscastro76](https://github.com/jscastro76), some enhancements and bugs.

#### ✨ Enhancements
- #212 Allow to remove an object by name
- #211 Create an object property that changes all the materials by a color
- #169 Update to Three.js v127
  - #214 Full refactor of tb.tube
  - #215 Refactor tb.line
  - #216 Refactor tb.update
  - #217 utils.material should allow THREE.DoubleSide
  - #218 Remove CustomEvent from events
  - #219 Remove .getInverse()
  - #220 Update Loaders
  - #221 Add fflate module

#### 🪲 Bug fixes
- #222 fflate depends on a physical file

#### 📝 Documentation
- Updated [documentation](/docs/Threebox.md) (`obj.color`, `tb.removeByName`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jscastro76 jscastro76

Labels
📑 code improvement 🔗 external dependencies
Projects
None yet
Milestone
v2.2.1.
Development

No branches or pull requests
1 participant
@jscastro76