Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug on init params bbox and tooltip #168

Closed
jscastro76 opened this issue Jan 12, 2021 · 0 comments
Closed

Bug on init params bbox and tooltip #168

jscastro76 opened this issue Jan 12, 2021 · 0 comments
Assignees
@jscastro76
Labels
🪲 bug Something isn't working
Milestone
v.2.1.7.

Comments

@jscastro76
Copy link
Owner

jscastro76 commented Jan 12, 2021 •
edited
Loading

These 2 init params don't work as expected. Discovered at #166

  • If raycast is active through enableSelectingObjects: true in threebox and bbox: false in the object, it shouldn't show the bbox even if it still visible for raycasting. If bbox: true but enableSelectingObjects: false it doesn't have any effect as the object is not raycasted.
  • If raycast is active through enableSelectingObjects: true in threebox and tooltip: false in the object, it shouldn't show the tooltip even if it still visible for raycasting. If tooltip: true but enableSelectingObjects: false it doesn't have any effect as the object is not raycasted.
@jscastro76 jscastro76 added the 🪲 bug Something isn't working label Jan 12, 2021
@jscastro76 jscastro76 added this to the v.2.1.7. milestone Jan 12, 2021
@jscastro76 jscastro76 self-assigned this Jan 12, 2021
jscastro76 added a commit that referenced this issue Jan 12, 2021
@jscastro76
#168 Bug on init params bbox and tooltip. Related to #166
e4cf4f1
jscastro76 added a commit that referenced this issue Jan 20, 2021
@jscastro76
## 2.1.7
190cb93 
Minor version by [@jscastro76](https://github.com/jscastro76), some enhancements and bugs.

#### ✨ Enhancements
- #155 How to keep fixed scale and size of Airplane 3D model when zoom in or out Mapbox?
- #167 Create a new event `ObjectChanged` every time the object has modified its position, rotation or scale.
  - Related to #163 request to get coordinates when the model follow path with line?
  - Modified example [05-logistics.html](https://github.com/jscastro76/threebox/blob/master/examples/05-logistics.html) to attach to the event `ObjectChanged`
  - Modified example [11-logistics.html](https://github.com/jscastro76/threebox/blob/master/examples/11-animation.html) to attach to the event `ObjectChanged`
 - Modified example [08-3dbuildings.html](https://github.com/jscastro76/threebox/blob/master/examples/08-3dbuildings.html) to adjust perspective and position to a more relevant zone (empire state building)
- #170 Refactor internal methods
- #179 Create a new example for fixed scale model
  - Added to [19-fixedZoom.html](https://github.com/jscastro76/threebox/blob/master/examples/19-fixedZoom.html) that shows shows how to have a fixed scale for an object at a concrete zoom level. In that way the object with preserve the same visual size when the zoom is lower than the fixed zoom value.
- #181 Move npm modules to devDependencies and remove not used

#### 🪲 Bug fixes
- #168 Bug on init params `bbox` and `tooltip`
- #175 Shadows are not updated if an object is moved through animations
- #180 Fixed scale objects not being rescaled if they are being animated

#### 📝 Documentation
- Updated [documentation](/docs/Threebox.md) (`ObjectChanged`, `setFixedZoom`, `setObjectScale`, `setScale`, `modelHeight`, `unitsPerMeter` and other events)
- Updated [README.md](/).
- Updated [Examples](/examples) documentation (`19-fixedzoom.html`).
@jscastro76 jscastro76 mentioned this issue Feb 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jscastro76 jscastro76

Labels
🪲 bug Something isn't working
Projects
None yet
Milestone
v.2.1.7.
Development

No branches or pull requests
1 participant
@jscastro76