Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Worldwide view demos, have precision issues after #143 #145

Closed
jscastro76 opened this issue Dec 14, 2020 · 1 comment
Closed

Worldwide view demos, have precision issues after #143 #145

jscastro76 opened this issue Dec 14, 2020 · 1 comment
Assignees
@jscastro76
Labels
🪲 bug Something isn't working
Milestone
v.2.1.5.

Comments

@jscastro76
Copy link
Owner

jscastro76 commented Dec 14, 2020 •
edited
Loading

02-line.html and 04-mercator.html present incomplete items painted when pitch > 0 and < 60. This is due to the new calculation o the furthestdistance in CameraSync.

image
@jscastro76 jscastro76 added the 🪲 bug Something isn't working label Dec 14, 2020
@jscastro76 jscastro76 added this to the v.2.1.4. milestone Dec 14, 2020
@jscastro76 jscastro76 self-assigned this Dec 14, 2020
@jscastro76 jscastro76 modified the milestones: v.2.1.4., v.2.1.5. Dec 14, 2020
jscastro76 added a commit that referenced this issue Dec 18, 2020
@jscastro76
## 2.1.5
3758579 
Minor version by [@jscastro76](https://github.com/jscastro76), some enhancements and bugs.

#### ✨ Enhancements
- #3 Make Color of the boundingBox and boundingBoxShadow configurable
- #29 Make one object not selectable or draggable independently of Threebox params
- #150 Check methods doing traverse to avoid doing unnecessary loops

#### 🪲 Bug fixes
- #145 Worldwide view demos, have precision issues after #143
- #149 `obj.set` with `options.coords` doesn't change the z axis in obj.coordinates
@jscastro76
Copy link
Owner Author

Now we have pixel precision level at deep, medium and low zoom, apart from perfect alignment for the long bar in sample 7

image
image
image
image

jscastro76 added a commit that referenced this issue Dec 19, 2020
@jscastro76
#151 Removed auxiliare test method from CameraSync, used to debug #145
3541034
This was referenced Dec 22, 2020
Closed
Closed
jscastro76 added a commit that referenced this issue Jan 5, 2021
@jscastro76
## 2.1.6
8a7385e 
Minor version by [@jscastro76](https://github.com/jscastro76), some enhancements and bugs.

#### ✨ Enhancements

- #111 Show the dimensions of a model
- #151 Remove auxiliary test method on `CameraSync` used to debug #145
- #156 Create an Orthographic view mode
- #159 Create an example for FOV and Orthographic.
  - Added to [09-raycaster.html](https://github.com/jscastro76/threebox/blob/master/examples/09-raycaster.html) as it impacts in raycast and shows fill-extrusions and 3D models together
- #161 Remove obsolete code that is avoiding to be used from React

#### 🪲 Bug fixes
- #152 `obj.raycasted` is ignored when an object is hidden and again visible.
- #157 Bug draggging after removing an object.
- #160 Bug using `utils.equal`

#### 📝 Documentation
- #158 MERCATOR_A constant unused, added an code comment to explain why it was deprecated (nor removed)
- Updated [documentation](/docs/Threebox.md) (`tb.orthographic`, `tb.fov`)
- Updated [README.md](/).
- Updated [Examples](/examples) documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jscastro76 jscastro76

Labels
🪲 bug Something isn't working
Projects
None yet
Milestone
v.2.1.5.
Development

No branches or pull requests
1 participant
@jscastro76