#42 Change ito avoid using a mapboxgl.Point

jscastro76 · Nov 8, 2020 · 0d8ba60 · 0d8ba60
1 parent c433aa4
commit 0d8ba60
Show file tree

Hide file tree

Showing 6 changed files with 22 additions and 17 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,7 @@ Minor version by [@jscastro76](https://github.com/jscastro76), some enhancements
 
 #### :beetle: Bug fixes
 
+- [**#42**](https://github.com/jscastro76/threebox/issues/77) Angular and Threebox. Solved an issue using a `mapboxgl.Point`line
 - [**#77**](https://github.com/jscastro76/threebox/issues/77) example 05-logistics raises an error removing the line
 - [**#79**](https://github.com/jscastro76/threebox/issues/79) Some examples are not using `renderingMode: 3d` in the layer creation 
 

diff --git a/README.md b/README.md
@@ -11,6 +11,10 @@ A **[*Three.js*](https://threejs.org/)** plugin for **[*Mapbox GL JS*](https://d
 
 Current release is [**2.0.7**](https://github.com/jscastro76/threebox/releases/tag/v.2.0.7), please review the [**Change log**](https://github.com/jscastro76/threebox/blob/master/CHANGELOG.md#207) for more details.
 
+Threebox is available as an [nmp package](https://www.npmjs.com/package/threebox-plugin)
+```js
+npm i threebox-plugin
+```
 <br>
 
 - - -
@@ -93,7 +97,7 @@ All the [**Threebox Documentation**](/docs/Threebox.md) has been completely upda
 You can use threebox in two different ways. 
 
 #### NPM install
-Add threebox to your project via npm:
+Add threebox to your project via [npm package](https://www.npmjs.com/package/threebox-plugin):
 
 `npm install threebox-plugin`
 

diff --git a/dist/threebox.js b/dist/threebox.js
@@ -145,10 +145,10 @@ Threebox.prototype = {
 			// Return the xy coordinates of the mouse position
 			function mousePos(e) {
 				var rect = canvas.getBoundingClientRect();
-				return new mapboxgl.Point(
-					e.originalEvent.clientX - rect.left - canvas.clientLeft,
-					e.originalEvent.clientY - rect.top - canvas.clientTop
-				);
+				return {
+					x: e.originalEvent.clientX - rect.left - canvas.clientLeft,
+					y: e.originalEvent.clientY - rect.top - canvas.clientTop
+				};
 			}
 
 			function unselectFeature(f, map) {
@@ -879,7 +879,7 @@ Threebox.prototype = {
 
 	programs: function () { return this.renderer.info.programs.length },
 
-	version: '2.0.7',
+	version: '2.0.8',
 
 }
 

diff --git a/dist/threebox.min.js b/dist/threebox.min.js
diff --git a/src/Threebox.js b/src/Threebox.js
@@ -140,10 +140,10 @@ Threebox.prototype = {
 			// Return the xy coordinates of the mouse position
 			function mousePos(e) {
 				var rect = canvas.getBoundingClientRect();
-				return new mapboxgl.Point(
-					e.originalEvent.clientX - rect.left - canvas.clientLeft,
-					e.originalEvent.clientY - rect.top - canvas.clientTop
-				);
+				return {
+					x: e.originalEvent.clientX - rect.left - canvas.clientLeft,
+					y: e.originalEvent.clientY - rect.top - canvas.clientTop
+				};
 			}
 
 			function unselectFeature(f, map) {
@@ -874,7 +874,7 @@ Threebox.prototype = {
 
 	programs: function () { return this.renderer.info.programs.length },
 
-	version: '2.0.7',
+	version: '2.0.8',
 
 }
 

diff --git a/tests/threebox-tests-bundle.js b/tests/threebox-tests-bundle.js
@@ -9084,10 +9084,10 @@ Threebox.prototype = {
 			// Return the xy coordinates of the mouse position
 			function mousePos(e) {
 				var rect = canvas.getBoundingClientRect();
-				return new mapboxgl.Point(
-					e.originalEvent.clientX - rect.left - canvas.clientLeft,
-					e.originalEvent.clientY - rect.top - canvas.clientTop
-				);
+				return {
+					x: e.originalEvent.clientX - rect.left - canvas.clientLeft,
+					y: e.originalEvent.clientY - rect.top - canvas.clientTop
+				};
 			}
 
 			function unselectFeature(f, map) {
@@ -9818,7 +9818,7 @@ Threebox.prototype = {
 
 	programs: function () { return this.renderer.info.programs.length },
 
-	version: '2.0.7',
+	version: '2.0.8',
 
 }