updated area,thickness and ocp function

js1tr3 · Oct 3, 2023 · 888cfa9 · 888cfa9
1 parent d276af8
commit 888cfa9
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 13 deletions.
diff --git a/degradation_model/initialize_model.ipynb b/degradation_model/initialize_model.ipynb
@@ -121,6 +121,8 @@
     "        \"Initial concentration in positive electrode [mol.m-3]\":cs_p_init,\n",
     "        \"Initial temperature [K]\": 273.15+25,\n",
     "        \"Ambient temperature [K]\": 273.15+25,\n",
+    "        \"Lower voltage cut-off [V]\":2.7,\n",
+    "        \"Upper voltage cut-off [V]\":4.2,\n",
     "    },\n",
     "    check_already_exists=False,\n",
     ")"

diff --git a/pybamm/input/parameters/lithium_ion/cells/UMBL_Siegel2022/parameters.csv b/pybamm/input/parameters/lithium_ion/cells/UMBL_Siegel2022/parameters.csv
@@ -3,12 +3,12 @@ Name [units],Value,Reference,Notes
 ,,,
 # Macroscale geometry,,,
 Negative current collector thickness [m],1E-05,Siegel fukuda cu,
-Negative electrode thickness [m],55.605E-06,Siegel2022,
+Negative electrode thickness [m],60.6E-06,Siegel2022,
 Separator thickness [m],12E-06,MPM Etek 12EPH,
-Positive electrode thickness [m],55.65E-06,Siegel2022,
+Positive electrode thickness [m],63.15E-06,Siegel2022,
 Positive current collector thickness [m],1.5E-05,Scott Moura FastDFN,no info from Peyman MPM
 Electrode height [m],106e-3,UMBL Pouch,Not needed for 1D
-Electrode width [m],1.35,UMBL Pouch,Not needed for 1D 18*68e-3 12 layer pouch
+Electrode width [m],0.125,UMBL Pouch,Not needed for 1D 18*68e-3 12 layer pouch
 Cell cooling surface area [m2],0.41,,pouch
 Cell volume [m3],3.92E-5,,pouch
 ,,,

diff --git a/...mm/input/parameters/lithium_ion/positive_electrodes/NMC_UMBL_Siegel2022/NMC_ocp_Siegel.py b/...mm/input/parameters/lithium_ion/positive_electrodes/NMC_UMBL_Siegel2022/NMC_ocp_Siegel.py
@@ -16,16 +16,29 @@ def NMC_ocp_Siegel(sto):
        Stochiometry of material (li-fraction)
 
     """
-
-    u_eq = (
-        4.396
-        - 1.538 * sto
-        + 0.7194 * (sto ** 2)
-        - 0.009979 * (sto ** 3)
-        + 1.074 * (sto ** 4)
-        - 1.075 * (sto ** 5)
-        - 4.071 * pybamm.exp(75 * sto - 80.9)
-    )
+    # old function fitted between 0 and 1 stoic
+    # u_eq = (
+    #     4.396
+    #     - 1.538 * sto
+    #     + 0.7194 * (sto ** 2)
+    #     - 0.009979 * (sto ** 3)
+    #     + 1.074 * (sto ** 4)
+    #     - 1.075 * (sto ** 5)
+    #     - 4.071 * pybamm.exp(75 * sto - 80.9)
+    # )
+
+    p1 = -115.4130
+    p2 = -0.1494
+    p3 = 1.3186e+03
+    p4 = -3.2289e+03
+    p5 = 3.5845e+03
+    p6 = -2.1824e+03
+    p7 = 749.4893
+    p8 = -134.6208
+    p9 = 7.3118
+    p10 = 5.0000
+
+    u_eq =  p1*sto**9 + p2*sto**8 + p3*sto**7 + p4*sto**6 + p5*sto**5 + p6*sto**4 + p7*sto**3 + p8*sto**2 + p9*sto + p10
 
     return u_eq