Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first #1

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

VolgaMashchytskaya
Copy link

No description provided.

@jsru-1
Copy link
Contributor

jsru-1 commented Dec 29, 2024

Спасибо за отправленный пулриквест, теперь @ShGKme должен запустить тесты.

@jsru-1
Copy link
Contributor

jsru-1 commented Dec 29, 2024

Проверьте, пожалуйста, ваше решение, не все тесты прошли (PR не будет принят до тех пор, пока все добавленные задачи не будут решены).

01-basics/10-create-app/script.js Outdated Show resolved Hide resolved
01-basics/20-weather/WeatherApp.js Outdated Show resolved Hide resolved
01-basics/20-weather/WeatherApp.js Outdated Show resolved Hide resolved
01-basics/20-weather/WeatherApp.js Outdated Show resolved Hide resolved
01-basics/10-create-app/script.js Outdated Show resolved Hide resolved
@jsru-1
Copy link
Contributor

jsru-1 commented Dec 29, 2024

Добавляю преподавателя (@ShGKme) для код-ревью.

@jsru-1 jsru-1 requested a review from ShGKme December 29, 2024 22:32
@jsru-1
Copy link
Contributor

jsru-1 commented Dec 30, 2024

Проверьте, пожалуйста, ваше решение, не все тесты прошли (PR не будет принят до тех пор, пока все добавленные задачи не будут решены).

var day = new Date();

return {
today: day.toLocaleDateString('navigator.language', { dateStyle: 'long' })
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

navigator.language - это свойство JS объекта, а не строка:

https://developer.mozilla.org/ru/docs/Web/API/Navigator/language

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants