Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve 02-basics/counter, 02-basics/broken-map, 02-basics/calculator, 02-basics/marked-emails #2

Merged
merged 8 commits into from
Dec 23, 2024
Merged

Solve 02-basics/counter, 02-basics/broken-map, 02-basics/calculator, 02-basics/marked-emails #2

merged 8 commits into from
Dec 23, 2024

Conversation

KristinaKhlebnikova
Copy link
Contributor

No description provided.

@jsru-1
Copy link
Contributor

jsru-1 commented Dec 17, 2024

Добавляю преподавателя (@ShGKme) для код-ревью.

@jsru-1 jsru-1 requested a review from ShGKme December 17, 2024 14:18
@jsru-1
Copy link
Contributor

jsru-1 commented Dec 17, 2024

Проверьте, пожалуйста, ваше решение, не все тесты прошли (PR не будет принят до тех пор, пока все добавленные задачи не будут решены).

@jsru-1
Copy link
Contributor

jsru-1 commented Dec 17, 2024

Решение было обновлено, посмотрим что скажет @ShGKme

@KristinaKhlebnikova KristinaKhlebnikova changed the title Solve 02-basics/counter Solve 02-basics/counter, 02-basics/broken-map Dec 17, 2024
@jsru-1
Copy link
Contributor

jsru-1 commented Dec 17, 2024

Проверьте, пожалуйста, ваше решение, не все тесты прошли (PR не будет принят до тех пор, пока все добавленные задачи не будут решены).

@ShGKme
Copy link
Contributor

ShGKme commented Dec 17, 2024

Решённые задачи приняты, но есть новые добавленные задачи

@jsru-1
Copy link
Contributor

jsru-1 commented Dec 20, 2024

Проверьте, пожалуйста, ваше решение, не все тесты прошли (PR не будет принят до тех пор, пока все добавленные задачи не будут решены).

@jsru-1
Copy link
Contributor

jsru-1 commented Dec 20, 2024

Проверьте, пожалуйста, ваше решение, не все тесты прошли (PR не будет принят до тех пор, пока все добавленные задачи не будут решены).

@KristinaKhlebnikova KristinaKhlebnikova changed the title Solve 02-basics/counter, 02-basics/broken-map Solve 02-basics/counter, 02-basics/broken-map, 02-basics/calculator Dec 20, 2024
@jsru-1
Copy link
Contributor

jsru-1 commented Dec 20, 2024

Решение было обновлено, посмотрим что скажет @ShGKme

@KristinaKhlebnikova KristinaKhlebnikova changed the title Solve 02-basics/counter, 02-basics/broken-map, 02-basics/calculator Solve 02-basics/counter, 02-basics/broken-map, 02-basics/calculator, 02-basics/marked-emails Dec 20, 2024
ShGKme
ShGKme requested changes Dec 20, 2024
View reviewed changes
02-basics-2/30-calculator/CalculatorApp.js Outdated Show resolved Hide resolved
02-basics-2/40-marked-emails/MarkedEmailsApp.js Outdated Show resolved Hide resolved
@jsru-1
Copy link
Contributor

jsru-1 commented Dec 23, 2024

Добавляю преподавателя (@ShGKme) для код-ревью.

@jsru-1 jsru-1 requested a review from ShGKme December 23, 2024 12:47
ShGKme
ShGKme approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Принято

02-basics-2/30-calculator/CalculatorApp.js Show resolved Hide resolved
@jsru-1 jsru-1 merged commit fe8bff5 into js-tasks-ru:master Dec 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KristinaKhlebnikova @jsru-1 @ShGKme