Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ws-debug.js.org #9520

Merged
merged 4 commits into from
Jan 23, 2025
Merged

ws-debug.js.org #9520

merged 4 commits into from
Jan 23, 2025

Conversation

YShenZe
Copy link
Contributor

@YShenZe YShenZe commented Jan 22, 2025

The site content is A WebSocket Debugging Tool Using Vue。business problem, don't turn on SSL。Because of the procedure problem, it needs to be effective in the root directory (that is, after the domain name application is successful).

cnames_active.js Outdated Show resolved Hide resolved
@MattIPv4 MattIPv4 added invalid awaiting response This PR is waiting for a response from the requester labels Jan 22, 2025
@indus indus added the name mismatch This PR has a subdomain request that does not align with the requester or target label Jan 22, 2025
@indus
Copy link
Member

indus commented Jan 22, 2025

@YShenZe besides the problem with the alphabetical order, I would like to ask you to request a subdomain like ws-debug or websocket_test or similar as the websocket is quite generic for a tool that is quite specific in its functionality.

And as a result of using a user repo for your project instead of a project-repo there is a name-mismatch.
FYI: https://github.com/js-org/js.org/wiki/Subdomain-Determination

@YShenZe
Copy link
Contributor Author

YShenZe commented Jan 23, 2025

Okay, thanks for reminding me.

@YShenZe
Copy link
Contributor Author

YShenZe commented Jan 23, 2025

And I always thought that Github Pages could only apply for one, but I found out that I could apply for more than one.

@YShenZe
Copy link
Contributor Author

YShenZe commented Jan 23, 2025

It has been revised according to the requirements.Forgive me for not knowing how to modify the pr title.

@indus indus changed the title websocket.js.org ws-debug.js.org Jan 23, 2025
@indus indus added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account awaiting CNAME This PR is waiting for the target to add a CNAME file and removed invalid name mismatch This PR has a subdomain request that does not align with the requester or target awaiting response This PR is waiting for a response from the requester labels Jan 23, 2025
@indus
Copy link
Member

indus commented Jan 23, 2025

I've already added your requested subdomain to JS.ORGs zonefile. But you have to (re-)add a file named CNAME to your branch with the single line ws-debug.js.org to make it work.
I'll merge after we have "contact". Please keep this PR open.

@YShenZe
Copy link
Contributor Author

YShenZe commented Jan 23, 2025

I've already added your requested subdomain to JS.ORGs zonefile. But you have to (re-)add a file named CNAME to your branch with the single line ws-debug.js.org to make it work.
I'll merge after we have "contact". Please keep this PR open.

I've added the CNAME file.

@indus indus removed the awaiting CNAME This PR is waiting for the target to add a CNAME file label Jan 23, 2025
@indus
Copy link
Member

indus commented Jan 23, 2025

Welcome https://ws-debug.js.org

@indus indus merged commit c478777 into js-org:master Jan 23, 2025
1 check passed
@YShenZe
Copy link
Contributor Author

YShenZe commented Jan 23, 2025

Welcome https://ws-debug.js.org

Turn off SSL. Thank you.Because SSL causes non-wss protocol WebSockets to fail to debug

@indus
Copy link
Member

indus commented Jan 23, 2025

You have to open a new PR and add the // noCF comment behind your line. FYI: https://github.com/js-org/js.org/blob/master/cnames_active.js#L17-L20

@YShenZe
Copy link
Contributor Author

YShenZe commented Jan 23, 2025

A new Pr has been opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants