Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add_foreign_key silently does not create foreign keys #656

Closed
mjc opened this issue Jun 10, 2015 · 5 comments
Closed

add_foreign_key silently does not create foreign keys #656

mjc opened this issue Jun 10, 2015 · 5 comments

Comments

@mjc
Copy link
Contributor

mjc commented Jun 10, 2015

I'm working up a test case, but I'm curious if this is expected since 4.2 support is not done yet?
@kares
Copy link
Member

kares commented Jun 11, 2015

@mjc probably ... did some work on 1-3-stable lately please try against it (as well) if possible
although none was explicitly add_foreign_key related ... we will definitely need more details here :)

@mjc
Copy link
Contributor Author

mjc commented Jun 11, 2015

Still does not generate foreign keys on 4679495.

I'll try and make a reduced test case today.

@mjc
Copy link
Contributor Author

mjc commented Jun 11, 2015

Test case

kares added a commit that referenced this issue Jun 11, 2015
@kares
[postgres] foreign_key support back-ported from AR 4.2 (fixes #656)
f161ccb
@mjc
Copy link
Contributor Author

mjc commented Jun 11, 2015

f161ccb may fix this for postgres but it does not fix it for mysql, which is my primary test case. Thanks for responding so quickly though 👍

kares added a commit that referenced this issue Jun 12, 2015
@kares
[mysql] foreign key support based on AR 4.2 (fixes #656)
579545a
@kares
Copy link
Member

kares commented Jun 12, 2015

@mjc do not get use to it much ... you had a good timing catching me baking an AR-JDBC release :)

please test if you can and let us know if you run into any issues using 1-3-stable

@kares kares closed this as completed Jun 12, 2015
kares added a commit that referenced this issue Jun 13, 2015
@kares
Merge branch '1-3-stable'
cec4fba 
* 1-3-stable: (43 commits)
  one last place of missed shared AR4x constants refactoring (thanks travis-ci!)
  missed places for updating to using shared AR4x constants
  use the (shared) AR4x constants in PostgreSQL adapter
  move AR4x constants to (top-level) ArJdbc
  adapt schema dump test on AR 4.2 ... *t.string \"id\", limit: 255, null: false* now
  [mysql] bulk compatibility with AR 4.2 - all _sql helper accept an options (hash)
  [mysql] back-port case sensitive/insensitive comparison
  [mysql] handle precision for datetimes when doing type_to_sql (AR 4.2 compat)
  adjust foreign key test introduced in #629 (was failing with MRI under AR 4.2.1)
  [mysql] schema creation compatibility with AR 4.2 (drop FK & temporayr tables)
  [mysql] validate_index_length! when available
  [mysql] foreign key support based on AR 4.2 (fixes #656)
  review foreign_key support in Postgres adapter (extract helper should be private)
  AR 4.2 valid_type? method for all
  finish up the foreign key test - more asserts less puts
  [postgres] drop_table backported to support `:force => :cascade` option
  [postgres] foreign_key support back-ported from AR 4.2 (fixes #656)
  [postgres] primary_key compatibility with latest AR
  export `open?` and ("raw") `close` helpers on the JDBC connection side
  alias jdbc_connection active? as valid? (just so its clearer on what it does)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mjc @kares