Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no more .jrubydir files for /specifications/* and /gems/** #258

Closed
mkristian opened this issue Nov 12, 2015 · 2 comments
Closed

no more .jrubydir files for /specifications/* and /gems/** #258

mkristian opened this issue Nov 12, 2015 · 2 comments
Labels

Comments

@mkristian
Copy link
Contributor

build.gradle

buildscript {
  repositories {
    jcenter()
  }
  dependencies {
    classpath "com.github.jruby-gradle:jruby-gradle-jar-plugin:1.1.4"
  }
}
apply plugin: 'com.github.jruby-gradle.jar'
repositories {
  jcenter()
}
dependencies {
  jrubyJar 'rubygems:rake:10.4.2'
}
jrubyJar {
    from('.') { include 'Rakefile' }
}

Rakefile

p __FILE__
p dir = Gem.loaded_specs['rake'].full_gem_path
p Gem.path
p Gem::Specification.dirs
p Dir[ "uri:classloader://specifications/*" ]

which gives:

$ ./gradlew jrubyJar
$ java -jar build/libs/gradle-jruby.jar -S rake -T
"uri:classloader:/Rakefile"
"file:/Users/cmeier/projects/sandbox/gradle/build/libs/gradle-jruby.jar!/gems/rake-10.4.2"
["uri:classloader://", "uri:classloader://META-INF/jruby.home/lib/ruby/gems/shared"]
["uri:classloader:/specifications", "uri:classloader:/specifications", "uri:classloader://META-INF/jruby.home/lib/ruby/gems/shared/specifications", "uri:classloader:/specifications", "file:/Users/cmeier/projects/sandbox/gradle/build/libs/gradle-jruby.jar!/specifications"]
["uri:classloader://specifications/jar-dependencies-0.1.15.gemspec"]
@mkristian mkristian added the jar label Nov 12, 2015
@rtyler
Copy link
Member

rtyler commented Nov 13, 2015

So I'm clear, the expected behavior is that specifications/ and gems/ should have .jrubydir files inside of them, but do not after the transformer type change that I had made right?

@mkristian
Copy link
Contributor Author

yes, and things work as JRuby tries to find a way around the missing "."
files which works in some cases and in other it does not work. yes the
transformer does add the .jrubydir files at places where we could leave
them out like /org/jruby/** but that does not harm as it is. the missing
ones fail to run the UAT runners at lookout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants