Skip to content

Commit

Permalink
Merge pull request #94 from ysb33r/master
Browse files Browse the repository at this point in the history
FIXED #83. Updates for appveyor and fix to Windows issue
  • Loading branch information
ysb33r committed Dec 20, 2014
2 parents 33b48a6 + 434a916 commit 3147226
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
9 changes: 8 additions & 1 deletion appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,17 @@ build_script:
- gradlew.bat assemble --info

test_script:
- gradlew.bat check --info
- gradlew.bat test check --info

This comment has been minimized.

Copy link
@mojavelinux

mojavelinux Dec 20, 2014

Contributor

Isn't this redundant. I believe that check invokes test (not that it really matters).

This comment has been minimized.

Copy link
@ysb33r

ysb33r Dec 20, 2014

Author Contributor

It is actually.


branches:
only:
- master
- development

environment:
matrix:
- JAVA_HOME: C:\Program Files\Java\jdk1.7.0
- JAVA_HOME: C:\Program Files\Java\jdk1.8.0
- JAVA_HOME: C:\Program Files (x86)\Java\jdk1.7.0
- JAVA_HOME: C:\Program Files (x86)\Java\jdk1.8.0

5 changes: 5 additions & 0 deletions src/main/groovy/com/github/jrubygradle/GemUtils.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,11 @@ class GemUtils {
project.logger.debug "Gem installation: Working around bug in jruby 1.7.14"
environment HOME : project.gradle.gradleUserHomeDir.absolutePath
}

// Workaround for FFI bug that is seen on some Windows environments
if(System.getProperty('os.name').toLowerCase().startsWith('windows')) {
environment 'TMP' : System.env.TMP, 'TEMP' : System.env.TEMP

This comment has been minimized.

Copy link
@mojavelinux

mojavelinux Dec 20, 2014

Contributor

What's causing the environment to be reset? Is it JRuby?

This comment has been minimized.

Copy link
@ysb33r

ysb33r Dec 20, 2014

Author Contributor

We force it in the plugin as we don't want system-wide RUby to pollute the build

This comment has been minimized.

Copy link
@mojavelinux

mojavelinux Dec 20, 2014

Contributor

Gotcha. Why not just remove the known environment variables so you don't need hacks in the code?

This comment has been minimized.

Copy link
@mojavelinux

mojavelinux Dec 20, 2014

Contributor
}
}
}
}
Expand Down

1 comment on commit 3147226

@ysb33r
Copy link
Contributor Author

@ysb33r ysb33r commented on 3147226 Dec 20, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THat will be a second-round fix as some refactoring will need to be done at the same time

Please sign in to comment.