feat: Add option to hide navigation bar on home screen #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Many thanks for your contribution! I think the wording of "use full screen" vs "hide navigation bar" is now somewhat confusing. I'd suggest to Any thoughts? |
jrpie
reviewed
Feb 22, 2025
| decorView.systemUiVisibility = uiOptions | ||
|
|
||
| // Add listener to hide the navigation bar | ||
| decorView.setOnSystemUiVisibilityChangeListener { visibility -> |
There was a problem hiding this comment.
I don't understand why this listener is required. What might cause a visibility change that doesn't also trigger onWindowFocusChanged?
Also it seems strange to add a listener every time onWindowFocusChanged is called. If this listener is required, it should probably be moved to onCreate or onResume
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the launcher more minimal on older Android version, I'd like to add the ability for user to hide the navigation bar on home screen. Toggling the "Use full screen" option does not hide the navigation bar, so I looked for another way to do it. I have tested the changes on my phones running Android 8.1 and Android 14.
This is my first ever PR, so any guidance or comment is appreciated.