Add pointer initialization in MPU6050.cpp #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The uint8_t* verifyBuffer was uninitialized. I don't think this causes any problems, since it is only checked if verify is true, and that condition does initialize verifyBuffer elsewhere in the code. However, it's probably safer to initialize it to 0 or nullptr in case some future edit does something different.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
uint8_t* verifyBufferpointer was uninitialized. I don't think this causes any problems, sinceit is only checked if verify is true, and that condition does initialize verifyBuffer elsewhere
in the code. However, it's probably safer to initialize it to
0ornullptrin case some futureedit does something different.